Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update needed to support new version of Hapi and Joi #79

Open
rmothilal opened this issue Oct 10, 2019 · 7 comments
Open

Update needed to support new version of Hapi and Joi #79

rmothilal opened this issue Oct 10, 2019 · 7 comments

Comments

@rmothilal
Copy link
Contributor

Hapi and Joi have had a massive refactor of their libraries hapijs/joi#2037 hapi-openapi relies on this library to validate a swagger. The enjoi library needs an update to use these latest libraries so that hapi-openapi can use the latest version of this

@rmothilal
Copy link
Contributor Author

rmothilal commented Feb 26, 2020

@tlivings has there been any progress here? I have been doing a code upgrade on my fork https://github.com/rmothilal/enjoi/tree/feature/make-enjoi-compatible-with-joi-16
I am having issues with the allOf extension as well as the tests for override extensions.
Any assistance would be greatly appreciated @JoeScho @tlivings

@tlivings
Copy link
Owner

Want to submit a PR? I can pull it down and experiment.

@rmothilal
Copy link
Contributor Author

Hi @tlivings, thanks for the reply, I have created a PR #85
Please let me know what changes you require

@JoeScho
Copy link
Contributor

JoeScho commented Mar 3, 2020

Hey - poor timing on my behalf 😆 I also created a PR which I think fixes this #84. Please feel free to close it if you decide to merge #85

@rmothilal
Copy link
Contributor Author

@tlivings Have you managed to review anything in my PR?

@tlivings
Copy link
Owner

@rmothilal I am reviewing it. Thanks.

@svrnwnsch
Copy link

Is this fixed with new version 7.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants