diff --git a/README.md b/README.md index 887e7e76a..1493f749a 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ TLS-Scanner is a tool created by the Chair for Network and Data Security from th **Please note:** *TLS-Scanner is a research tool intended for TLS developers, pentesters, administrators and researchers. There is no GUI. It is in the first version and may contain some bugs.* # Compiling -In order to compile and use TLS-Scanner, you need to have Java and Maven installed, as well as [TLS-Attacker](https://github.com/RUB-NDS/TLS-Attacker) in Version 2.6 +In order to compile and use TLS-Scanner, you need to have Java and Maven installed, as well as [TLS-Attacker](https://github.com/RUB-NDS/TLS-Attacker) in Version 2.8 ```bash $ cd TLS-Scanner @@ -23,7 +23,7 @@ $ mvn clean install For hints on installing the required libraries checkout the corresponding GitHub repositories. -**Please note:** *In order to run this tool you need TLS-Attacker version 2.6* +**Please note:** *In order to run this tool you need TLS-Attacker version 2.8* # Running In order to run TLS-Scanner you need to run the jar file in the apps/ folder. diff --git a/pom.xml b/pom.xml index 3d535a167..5933c6e1b 100644 --- a/pom.xml +++ b/pom.xml @@ -3,18 +3,18 @@ 4.0.0 TLS-Scanner de.rub.nds.tlsscanner - 2.5 + 2.6 jar de.rub.nds.tlsattacker TLS-Core - 2.7 + 2.8 de.rub.nds.tlsattacker Attacks - 2.7 + 2.8 junit @@ -57,12 +57,12 @@ - TLS-Scanner + TLS-Scanner - - maven-dependency-plugin + + maven-dependency-plugin - + copy package @@ -83,17 +83,17 @@ copy-dependencies - package - - copy-dependencies - - + package + + copy-dependencies + + ${basedir}/apps/lib - compile - - - + compile + + + diff --git a/src/main/java/de/rub/nds/tlsscanner/probe/BleichenbacherProbe.java b/src/main/java/de/rub/nds/tlsscanner/probe/BleichenbacherProbe.java index 0a3195b1e..35c27e284 100644 --- a/src/main/java/de/rub/nds/tlsscanner/probe/BleichenbacherProbe.java +++ b/src/main/java/de/rub/nds/tlsscanner/probe/BleichenbacherProbe.java @@ -55,11 +55,12 @@ public ProbeResult executeTest() { } LOGGER.info("Fetched the following server public key: " + publicKey); List pkcs1Vectors; - if (scannerConfig.getScanDetail() == ScannerDetail.NORMAL) { - pkcs1Vectors = Pkcs1VectorGenerator.generatePkcs1Vectors(publicKey, BleichenbacherCommandConfig.Type.FAST, + if (scannerConfig.getScanDetail().isGreaterEqualTo(ScannerDetail.DETAILED)) { + pkcs1Vectors = Pkcs1VectorGenerator.generatePkcs1Vectors(publicKey, BleichenbacherCommandConfig.Type.FULL, bleichenbacherConfig.createConfig().getDefaultHighestClientProtocolVersion()); + } else { - pkcs1Vectors = Pkcs1VectorGenerator.generatePkcs1Vectors(publicKey, BleichenbacherCommandConfig.Type.FULL, + pkcs1Vectors = Pkcs1VectorGenerator.generatePkcs1Vectors(publicKey, BleichenbacherCommandConfig.Type.FAST, bleichenbacherConfig.createConfig().getDefaultHighestClientProtocolVersion()); } List resultList = new LinkedList<>(); diff --git a/src/main/java/de/rub/nds/tlsscanner/probe/PaddingOracleProbe.java b/src/main/java/de/rub/nds/tlsscanner/probe/PaddingOracleProbe.java index 32a33ce10..7a10ba094 100644 --- a/src/main/java/de/rub/nds/tlsscanner/probe/PaddingOracleProbe.java +++ b/src/main/java/de/rub/nds/tlsscanner/probe/PaddingOracleProbe.java @@ -128,10 +128,12 @@ public ProbeResult executeTest() { } } } - if (vulnerable && recordGeneratorType != PaddingRecordGeneratorType.SHORT) { + if (vulnerable && (ScannerDetail.QUICK != scannerConfig.getScanDetail())) { testResultList.clear(); //Perform full scan - recordGeneratorType = PaddingRecordGeneratorType.SHORT; + if (recordGeneratorType == PaddingRecordGeneratorType.VERY_SHORT) { + recordGeneratorType = PaddingRecordGeneratorType.SHORT; + } for (ProtocolVersion version : versionList) { VersionSuiteListPair suitePairList = null;