Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue?+Suggestion: Inability to Achieve Transparency Animation with Glowing Eyes Effect in Version 1.21.3. #702

Open
AshiraLOL opened this issue Oct 27, 2024 · 1 comment

Comments

@AshiraLOL
Copy link

Normal Functionality in older version

image

To make the light effect (Glowing Eyes) fade to transparency, you typically set the color to black, while white will make it visible.

Advantages

  • This method allows for creating animations that fade the light in or out, revealing the texture behind.

Disadvantages

  • The downside is that the colors can become distorted. Even when set to pure white, the effect remains somewhat transparent.
  • It’s necessary to use a black background texture or adjust the white light effect's color filter to prevent excessive color distortion.

Current Issue in Version 1.21.3

In version 1.21.3, it seems there is either a bug or a recent change in the lighting system :

  • You can no longer make the effect transparent.
  • When the "Color filter" with "Glowing Eyes" is set to black, it turns completely black and is no longer transparent.
  • Setting it to white does not cause color distortion, as it is not transparent at all.

This change can be seen as a solution to the color distortion in transparency, but it raises the question: what if you want the effect to be transparent?


left 1.21.1 And right 1.21.3
(both are CPM 0.16.19a)

No.more.Transparency.mp4

File model :
TestGlowColorSetBlackto0.zip

Suggestion

image

I propose adding an "Alpha Color" or "Alpha Channel" in the "Color filter" bar for lights. This would ensure that colors remain unaffected when creating transparent light animations.


Impact on Older Models

Currently, older models that used this transparency technique have turned into solid black or non-transparent versions. This affects:

  • Effects resembling outlines of models
  • Barrier armor effects
  • Clear glass effects

1.21.1
image

1.21.3
image
no more halloween glow effect. XD
*not my model


Summary

I appreciate the new lighting system (Glowing Eyes). I'm uncertain if the lack of transparency is a bug or a fix, but it effectively prevents color distortion, which is a benefit. However, I would still like to retain the ability to create transparent light effects. Adding an "Alpha" thing in the "Color filter" specifically for animations would be ideal.

More info - Tested with

  • Minecraft version 1.21.3 on both Fabric and Forge
  • No other mods on 1.21.3
  • CPM 0.16.19a
  • AMD RX570 graphics card
@AshiraLOL
Copy link
Author

I just tested version 1.21.2 and encountered the same issue.

tom5454 added a commit that referenced this issue Nov 7, 2024
24w45a port

Fixed glowing eyes on 1.21.3 (#702)
Fixed crash with Iris on 1.21.3 (Closes #701)
Fixed startup crash with Minecraft Forge on 1.21.3
FurryRbl pushed a commit to FurryRbl/CustomPlayerModels that referenced this issue Nov 9, 2024
24w45a port

Fixed glowing eyes on 1.21.3 (tom5454#702)
Fixed crash with Iris on 1.21.3 (Closes tom5454#701)
Fixed startup crash with Minecraft Forge on 1.21.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant