Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placing AE bridge breaks the server #35

Open
ArmaWizard opened this issue Aug 3, 2020 · 13 comments
Open

Placing AE bridge breaks the server #35

ArmaWizard opened this issue Aug 3, 2020 · 13 comments

Comments

@ArmaWizard
Copy link

I have a medium big logistics pipes system, but when I use the bridge pipe + AE bridge the server almost comes to halt.
It drops to around 5TPS, when i remove the bridge it instantly catches back up.

Placing AE bridge
image

Removing AE bridge
image

@ArmaWizard
Copy link
Author

ArmaWizard commented Aug 7, 2020

Note this is on 1.3.9 version. And latest stable logistics pipes version + appliedenergistics2-rv6-stable-7

Server runs on 16gb XMX - XMS 16 gigs on a 9900k.

tom5454 added a commit that referenced this issue Aug 17, 2020
Closes #36
Fixes #37
Closes #38
Fixes #40
Impooved Bridging Logic speed #33 #35
@tom5454
Copy link
Owner

tom5454 commented Aug 17, 2020

I optimized the bridging logic and added a profiler, please right click the AE bridge with a stick to see which part creates lag and send the report here.

@ArmaWizard
Copy link
Author

Will do

@ArmaWizard
Copy link
Author

Alright I just updated; but on server start:

---- Minecraft Crash Report ----
// I let you down. Sorry :(

Time: 2020-08-19 14:30:47 CEST
Description: Exception in server tick loop

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at com.tom.logisticsbridge.LogisticsBridge.registerPipe(LogisticsBridge.java:190)
at com.tom.logisticsbridge.LogisticsBridge.initItems(LogisticsBridge.java:164)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_2407_LogisticsBridge_initItems_Register.invoke(.dynamic)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
at net.minecraftforge.fml.common.eventhandler.EventBus$1.invoke(EventBus.java:144)
at net.minecraftforge.fml.common.eventhandler.EventBus.forgeBridge$post(EventBus.java:1259)
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:1206)
at net.minecraftforge.registries.GameData.fireRegistryEvents(GameData.java:850)
at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:630)
at net.minecraftforge.fml.server.FMLServerHandler.beginServerLoading(FMLServerHandler.java:99)
at net.minecraftforge.fml.common.FMLCommonHandler.onServerStart(FMLCommonHandler.java:333)
at net.minecraft.server.dedicated.DedicatedServer.init(DedicatedServer.java:125)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486)
at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.tom.logisticsbridge.LogisticsBridge.registerPipe(LogisticsBridge.java:188)
... 13 more
Caused by: java.lang.NoSuchFieldError: clientInv
at com.tom.logisticsbridge.pipe.CraftingManager.(CraftingManager.java:73)
at logisticspipes.pipes.basic.LogisticsBlockGenericPipe.createPipe(LogisticsBlockGenericPipe.java:197)
at logisticspipes.pipes.basic.LogisticsBlockGenericPipe.registerPipe(LogisticsBlockGenericPipe.java:183)
at logisticspipes.LogisticsPipes.registerPipe(LogisticsPipes.java:682)
... 18 more

Would you recommend placing the old version back in, removing the pipes, updating, adding the pipes again?

@ArmaWizard
Copy link
Author

Alright, did the above. Remove, update, add. Still crash on startup.

@ArmaWizard ArmaWizard reopened this Aug 19, 2020
tom5454 added a commit that referenced this issue Aug 20, 2020
Fixed crash with dedicated servers #35
Added blocking mode to AE and RS Crafting Managers
@tom5454
Copy link
Owner

tom5454 commented Aug 20, 2020

Fixed the crash on startup.

@ArmaWizard
Copy link
Author

root: 0.02ms
image

@ArmaWizard
Copy link
Author

I also have Spark Profiler installed if you need any more debug data. Let me know!

tom5454 added a commit that referenced this issue Aug 23, 2020
Performance improvements #35
Added more profiler points #43 #35
@tom5454
Copy link
Owner

tom5454 commented Aug 23, 2020

I added move options to the profiler and improved some parts of the code.

@ArmaWizard
Copy link
Author

Alright I will update and post the profiler output again.

tom5454 added a commit that referenced this issue Aug 30, 2020
Fixes #51
Fixes crash #50
#49 #35
@dominic-jones
Copy link

dominic-jones commented Aug 31, 2020

I too encountered a similar sounding issue. I connected a trivial AE system to a large (routing table size 1339) LP system. Immediately started getting slow and skipped ticks.

I suspect the problem gets worse over time. The first time I connected it, I was able to play for about five more minutes before being barely able to interact with any block.

Again on Logistics Bridge 1.13.11 in the FTBInteractions modpack.

Did you say this was fixed in later versions, or are you still gathering data?

I ran the diagnostic also. This is very shortly after connecting a bridge to the LP system. I can let it run for a while and take another diagnostic for you if that helps.
image

@desagas
Copy link

desagas commented Sep 21, 2020

I can confirm this in 2.0.9 Interactions, placing the bridge with the pipe connected caused 2 things to happen:

  1. About every 20 seconds or so, the bridge would spike tps, and would cause a major drop in performance.

  2. When requesting a crafting recipe through my request table, while having the bridge pipe and block connected to AE2 crafting grid and energy provider only, set to default and smart, the system instantly died. TPS dropped to 3, the bridge block was up to 9,100 ns/t, and the pridge pipe was at 50,000ns/t, and the crafting manager that was supposed to receive the items which were all available before connecting the bridge, shot up to 101,000ns/t. This never happened without the bridge connected. It seems as though this is a one way bridge only, crafting with AE2, and delivering with LP, but not the other way around.

@zanetano
Copy link

zanetano commented Feb 22, 2021

I have the same issue. (tps drops to 5 / tick time: 200ms and climbing until crash.)
I'm playing FTB Interactions 2.0.9 which has:
-Logi Bridge:1.3.11
-Logi Pipes:0.10.3.62
-AE:rv6-stable-7

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants