Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafting Manager with Buffer Upgrade oversends to Machines #59

Open
SonOfTheStars opened this issue Oct 10, 2020 · 4 comments · Fixed by JP-HellParadise/TestBridge#17
Open

Comments

@SonOfTheStars
Copy link

A crafting manager with a buffer upgrade will oversend items to a machine even after they have been buffered first, if Blocking mode can not be used or is otherwhise off. (See GTCE Extruder or Bending Machines)
This causes items to bounce back and forth between default chest and the machine constantly, generating lag.

Buffer upgrade should not attempt to oversend items into an machine that is already full.

@FairleyC
Copy link

FairleyC commented Jan 31, 2021

Can confirm, buffer will overfill the machine and items will be pushed to default route and pulled back to the machine until the the craft is finished.

I assume it's related to the default here always being true.

If instead it checked if the machine had room then it I believe it wouldn't over fill.

IInventoryUtil has a int roomForItem(@Nonnull ItemStack stack)

@FairleyC
Copy link

FairleyC commented Feb 1, 2021

A bit of a tangent but another note about blocking.

Since playing interactions I've used Logistics Pipes significantly and one of the problems the mod pack has is that certain machines need a Programmed Circuit that isn't consumed in the recipe. The current "Blocking" mode wont work with the machines that have these recipes. An exclusion list might be great for mod-pack makers.

@KorewaLidesu
Copy link

KorewaLidesu commented Jan 9, 2023

Could you try this, using a backup world?
This include test build of Logistics Pipes, and a custom mod
test.zip

@KorewaLidesu
Copy link

KorewaLidesu commented Jan 13, 2023

LP handler item transfer via pipe (aka transfer with packet)
Therefore no way to use roomForItem(@Nonnull ItemStack stack) if the recipe has multiple items in 1 space.
Atleast what I can fixed now is that you can transfer properly with recipe that has 1 item type / per sat if there is enough space for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants