Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why was support for deserializing to borrowing types dropped? #492

Closed
djc opened this issue Jan 24, 2023 · 2 comments
Closed

Why was support for deserializing to borrowing types dropped? #492

djc opened this issue Jan 24, 2023 · 2 comments

Comments

@djc
Copy link

djc commented Jan 24, 2023

In 0.6, toml::from_str() changed from having a Deserialize<'de> bound to having a DeserializeOwned bound. Why?
@epage
Copy link
Member

epage commented Jan 24, 2023

One thing we lose in using toml_edit for the parser is everything gets converted to an owned String before we deserialize, making it so borrows of the original source cannot happen.

@epage
Copy link
Member

epage commented Jan 24, 2023

I believe this is a dupe of #490, so closing in favor of that

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epage @djc