Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Wasm return value optimization #10

Open
crwen opened this issue Jan 6, 2025 · 0 comments
Open

Refactor: Wasm return value optimization #10

crwen opened this issue Jan 6, 2025 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@crwen
Copy link
Contributor

crwen commented Jan 6, 2025

Currently, js_sys::Reflect::set is used to convert JsRow to JsValue. It is better to implement it in a more efficient and elegant way.(via stdweb, for example)

tonbolite/src/connection.rs

Lines 215 to 220 in 5ced68a

for col in row.cols {
match col.value {
Value::Null => {
js_sys::Reflect::set(&object, &col.name.unwrap().into(), &JsValue::null())
.unwrap();
}

@ethe ethe assigned ethe and unassigned ethe Jan 7, 2025
@ethe ethe added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants