Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure class constructors work when passed empty strings or nothing #58

Closed
eritbh opened this issue Sep 25, 2023 · 1 comment · Fixed by #66
Closed

Ensure class constructors work when passed empty strings or nothing #58

eritbh opened this issue Sep 25, 2023 · 1 comment · Fixed by #66
Labels
bug Something isn't working good first issue Good for newcomers needs tests

Comments

@eritbh
Copy link
Member

eritbh commented Sep 25, 2023

Proper handling for subreddits which don't have any preexisting toolbox configuration / usernotes
@eritbh eritbh added bug Something isn't working good first issue Good for newcomers needs tests labels Sep 25, 2023
@eritbh eritbh mentioned this issue Mar 14, 2024
Merged
@eritbh
Copy link
Member Author

eritbh commented Mar 14, 2024

#63 fixes this for usernotes but how to handle this for sub config is an open question since we don't have handling for default values in a centralized location in Toolbox (and also since the sub config class here is not very fleshed out yet).

@fsvreddit fsvreddit mentioned this issue Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept empty input to SubredditConfig constructor fsvreddit/toolbox-devvit-fsv
1 participant
@eritbh