From fd1bd05bbd274fcd2b9fdea55f6b8fcc55b7c273 Mon Sep 17 00:00:00 2001
From: Justin Gasper <jmgasper@gmail.com>
Date: Mon, 1 Apr 2024 23:40:43 +0000
Subject: [PATCH 1/7] Hide download buttons for submissions that come from
 Topcrowd (TOP-655)

---
 .../SubmissionManagement/Submission/index.jsx | 14 ++++++++++++
 .../SubmissionManagement/index.jsx            |  2 ++
 .../SubmissionsTable/index.jsx                |  3 +++
 .../MySubmissions/SubmissionsList/index.jsx   | 22 ++++++++++++-------
 .../challenge-detail/MySubmissions/index.jsx  |  8 +------
 5 files changed, 34 insertions(+), 15 deletions(-)

diff --git a/src/shared/components/SubmissionManagement/Submission/index.jsx b/src/shared/components/SubmissionManagement/Submission/index.jsx
index 0bc769ed7a..02919206cd 100644
--- a/src/shared/components/SubmissionManagement/Submission/index.jsx
+++ b/src/shared/components/SubmissionManagement/Submission/index.jsx
@@ -27,6 +27,7 @@ import './styles.scss';
 
 export default function Submission(props) {
   const {
+    challenge,
     submissionObject,
     showScreeningDetails,
     track,
@@ -40,6 +41,16 @@ export default function Submission(props) {
   const onDownloadSubmission = onDownload.bind(1, submissionObject.id);
   const safeForDownloadCheck = safeForDownload(submissionObject.url);
 
+  // Determine if a challenge is for Topcrowd so we can edit the UI accordingly
+  let isTopCrowdChallenge = false;
+  const isTopCrowdChallengeData = _.find(challenge.metadata, { name: 'is_platform' });
+  if (isTopCrowdChallengeData) {
+    isTopCrowdChallenge = isTopCrowdChallengeData.value;
+  }
+  else {
+    isTopCrowdChallenge = false;
+  }
+
   return (
     <tr styleName="submission-row">
       <td styleName="id-col">
@@ -72,12 +83,14 @@ export default function Submission(props) {
        }
       <td styleName="action-col">
         <div>
+          { !isTopCrowdChallenge ?
           <button
             onClick={() => onDownloadSubmission(submissionObject.id)}
             type="button"
           >
             { safeForDownloadCheck === true && <DownloadIcon /> }
           </button>
+          : <span /> }
           { /*
              TODO: At the moment we just fetch downloads from the legacy
                Topcoder Studio API, and we don't need any JS code to this.
@@ -121,6 +134,7 @@ Submission.defaultProps = {
 };
 
 Submission.propTypes = {
+  challenge: PT.shape().isRequired,
   submissionObject: PT.shape({
     id: PT.string,
     legacySubmissionId: PT.string,
diff --git a/src/shared/components/SubmissionManagement/SubmissionManagement/index.jsx b/src/shared/components/SubmissionManagement/SubmissionManagement/index.jsx
index a467381a39..bd62794483 100644
--- a/src/shared/components/SubmissionManagement/SubmissionManagement/index.jsx
+++ b/src/shared/components/SubmissionManagement/SubmissionManagement/index.jsx
@@ -171,6 +171,7 @@ export default function SubmissionManagement(props) {
         {!loadingSubmissions
            && (
            <SubmissionsTable
+             challenge={challenge}
              submissionObjects={submissions}
              showDetails={showDetails}
              track={track}
@@ -212,6 +213,7 @@ SubmissionManagement.defaultProps = {
 };
 
 SubmissionManagement.propTypes = {
+  challenge: PT.shape().isRequired,
   showDetails: PT.shape().isRequired,
   onDelete: PT.func,
   onlineReviewUrl: PT.string,
diff --git a/src/shared/components/SubmissionManagement/SubmissionsTable/index.jsx b/src/shared/components/SubmissionManagement/SubmissionsTable/index.jsx
index 011930e4e5..b3d4317375 100644
--- a/src/shared/components/SubmissionManagement/SubmissionsTable/index.jsx
+++ b/src/shared/components/SubmissionManagement/SubmissionsTable/index.jsx
@@ -26,6 +26,7 @@ import './styles.scss';
 
 export default function SubmissionsTable(props) {
   const {
+    challenge,
     submissionObjects,
     showDetails,
     track,
@@ -56,6 +57,7 @@ export default function SubmissionsTable(props) {
 
       const submission = (
         <Submission
+          challenge={challenge}
           submissionObject={subObject}
           showScreeningDetails={showDetails[subObject.id]}
           track={track}
@@ -140,6 +142,7 @@ SubmissionsTable.defaultProps = {
 };
 
 SubmissionsTable.propTypes = {
+  challenge: PT.shape().isRequired,
   submissionObjects: PT.arrayOf(SubShape),
   showDetails: PT.shape().isRequired,
   track: PT.string.isRequired,
diff --git a/src/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx b/src/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx
index 1372a6e6db..efbd198121 100644
--- a/src/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx
+++ b/src/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx
@@ -187,6 +187,16 @@ class SubmissionsListView extends React.Component {
       timeClicked: false,
     };
 
+    // Determine if a challenge is for Topcrowd so we can edit the UI accordingly
+    let isTopCrowdChallenge = false;
+    const isTopCrowdChallengeData = _.find(challenge.metadata, { name: 'is_platform' });
+    if (isTopCrowdChallengeData) {
+      isTopCrowdChallenge = isTopCrowdChallengeData.value;
+    }
+    else {
+      isTopCrowdChallenge = false;
+    }
+
     return (
       <div styleName="wrapper">
         <div styleName="submission-table">
@@ -432,6 +442,7 @@ class SubmissionsListView extends React.Component {
                       <span>{moment(mySubmission.submissionTime).format('MMM DD, YYYY HH:mm:ss')}</span>
                     </div>
                     <div styleName="submission-table-column column-2-4">
+                      { !isTopCrowdChallenge ? 
                       <button
                         onClick={() => {
                           // download submission
@@ -450,7 +461,8 @@ class SubmissionsListView extends React.Component {
                         type="button"
                       >
                         <DownloadIcon />
-                      </button>
+                      </button> 
+                      : <span /> }
 
                       <button onClick={() => selectSubmission(mySubmission)} type="button">
                         <ZoomIcon styleName="icon-zoom" />
@@ -523,13 +535,7 @@ SubmissionsListView.defaultProps = {
 SubmissionsListView.propTypes = {
   selectSubmission: PT.func,
   challengesUrl: PT.string.isRequired,
-  challenge: PT.shape({
-    id: PT.any,
-    checkpoints: PT.arrayOf(PT.object),
-    submissions: PT.arrayOf(PT.object),
-    submissionViewable: PT.string,
-    registrants: PT.any,
-  }).isRequired,
+  challenge: PT.shape().isRequired,
   hasRegistered: PT.bool.isRequired,
   unregistering: PT.bool.isRequired,
   submissionEnded: PT.bool.isRequired,
diff --git a/src/shared/components/challenge-detail/MySubmissions/index.jsx b/src/shared/components/challenge-detail/MySubmissions/index.jsx
index d0d80eb630..ac96edd77b 100644
--- a/src/shared/components/challenge-detail/MySubmissions/index.jsx
+++ b/src/shared/components/challenge-detail/MySubmissions/index.jsx
@@ -125,13 +125,7 @@ MySubmissionsView.defaultProps = {
 
 MySubmissionsView.propTypes = {
   challengesUrl: PT.string.isRequired,
-  challenge: PT.shape({
-    id: PT.any,
-    checkpoints: PT.arrayOf(PT.object),
-    submissions: PT.arrayOf(PT.object),
-    submissionViewable: PT.string,
-    registrants: PT.any,
-  }).isRequired,
+  challenge: PT.shape().isRequired,
   hasRegistered: PT.bool.isRequired,
   unregistering: PT.bool.isRequired,
   submissionEnded: PT.bool.isRequired,

From ca3ea4465874295bcbaf5c2c8cc3fee35d1f25fa Mon Sep 17 00:00:00 2001
From: Justin Gasper <jmgasper@gmail.com>
Date: Tue, 2 Apr 2024 00:00:52 +0000
Subject: [PATCH 2/7] Lint

---
 .../SubmissionManagement/Submission/index.jsx | 21 +++++----
 .../SubmissionManagement/index.jsx            |  1 -
 .../MySubmissions/SubmissionsList/index.jsx   | 47 ++++++++++---------
 3 files changed, 35 insertions(+), 34 deletions(-)

diff --git a/src/shared/components/SubmissionManagement/Submission/index.jsx b/src/shared/components/SubmissionManagement/Submission/index.jsx
index 02919206cd..fb3b0231f0 100644
--- a/src/shared/components/SubmissionManagement/Submission/index.jsx
+++ b/src/shared/components/SubmissionManagement/Submission/index.jsx
@@ -46,8 +46,7 @@ export default function Submission(props) {
   const isTopCrowdChallengeData = _.find(challenge.metadata, { name: 'is_platform' });
   if (isTopCrowdChallengeData) {
     isTopCrowdChallenge = isTopCrowdChallengeData.value;
-  }
-  else {
+  } else {
     isTopCrowdChallenge = false;
   }
 
@@ -83,14 +82,16 @@ export default function Submission(props) {
        }
       <td styleName="action-col">
         <div>
-          { !isTopCrowdChallenge ?
-          <button
-            onClick={() => onDownloadSubmission(submissionObject.id)}
-            type="button"
-          >
-            { safeForDownloadCheck === true && <DownloadIcon /> }
-          </button>
-          : <span /> }
+          { !isTopCrowdChallenge
+            ? (
+              <button
+                onClick={() => onDownloadSubmission(submissionObject.id)}
+                type="button"
+              >
+                { safeForDownloadCheck === true && <DownloadIcon /> }
+              </button>
+            )
+            : <span /> }
           { /*
              TODO: At the moment we just fetch downloads from the legacy
                Topcoder Studio API, and we don't need any JS code to this.
diff --git a/src/shared/components/SubmissionManagement/SubmissionManagement/index.jsx b/src/shared/components/SubmissionManagement/SubmissionManagement/index.jsx
index bd62794483..5217eb3419 100644
--- a/src/shared/components/SubmissionManagement/SubmissionManagement/index.jsx
+++ b/src/shared/components/SubmissionManagement/SubmissionManagement/index.jsx
@@ -220,7 +220,6 @@ SubmissionManagement.propTypes = {
   helpPageUrl: PT.string,
   onDownload: PT.func,
   onShowDetails: PT.func,
-  challenge: PT.shape().isRequired,
   submissions: PT.arrayOf(PT.shape()),
   loadingSubmissions: PT.bool,
   challengeUrl: PT.string,
diff --git a/src/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx b/src/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx
index efbd198121..f1dfce87ef 100644
--- a/src/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx
+++ b/src/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx
@@ -192,8 +192,7 @@ class SubmissionsListView extends React.Component {
     const isTopCrowdChallengeData = _.find(challenge.metadata, { name: 'is_platform' });
     if (isTopCrowdChallengeData) {
       isTopCrowdChallenge = isTopCrowdChallengeData.value;
-    }
-    else {
+    } else {
       isTopCrowdChallenge = false;
     }
 
@@ -442,27 +441,29 @@ class SubmissionsListView extends React.Component {
                       <span>{moment(mySubmission.submissionTime).format('MMM DD, YYYY HH:mm:ss')}</span>
                     </div>
                     <div styleName="submission-table-column column-2-4">
-                      { !isTopCrowdChallenge ? 
-                      <button
-                        onClick={() => {
-                          // download submission
-                          const submissionsService = getService(auth.tokenV3);
-                          submissionsService.downloadSubmission(mySubmission.submissionId)
-                            .then((blob) => {
-                              const url = window.URL.createObjectURL(new Blob([blob]));
-                              const link = document.createElement('a');
-                              link.href = url;
-                              link.setAttribute('download', `submission-${mySubmission.submissionId}.zip`);
-                              document.body.appendChild(link);
-                              link.click();
-                              link.parentNode.removeChild(link);
-                            });
-                        }}
-                        type="button"
-                      >
-                        <DownloadIcon />
-                      </button> 
-                      : <span /> }
+                      { !isTopCrowdChallenge
+                        ? (
+                          <button
+                            onClick={() => {
+                              // download submission
+                              const submissionsService = getService(auth.tokenV3);
+                              submissionsService.downloadSubmission(mySubmission.submissionId)
+                                .then((blob) => {
+                                  const url = window.URL.createObjectURL(new Blob([blob]));
+                                  const link = document.createElement('a');
+                                  link.href = url;
+                                  link.setAttribute('download', `submission-${mySubmission.submissionId}.zip`);
+                                  document.body.appendChild(link);
+                                  link.click();
+                                  link.parentNode.removeChild(link);
+                                });
+                            }}
+                            type="button"
+                          >
+                            <DownloadIcon />
+                          </button>
+                        )
+                        : <span /> }
 
                       <button onClick={() => selectSubmission(mySubmission)} type="button">
                         <ZoomIcon styleName="icon-zoom" />

From a2b891a9c67060bf85af235697c30669b8282096 Mon Sep 17 00:00:00 2001
From: Justin Gasper <jmgasper@gmail.com>
Date: Tue, 2 Apr 2024 00:28:21 +0000
Subject: [PATCH 3/7] Fix test

---
 .../SubmissionManagement/Submission/index.jsx          | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/shared/components/SubmissionManagement/Submission/index.jsx b/src/shared/components/SubmissionManagement/Submission/index.jsx
index fb3b0231f0..c4ed0f70a1 100644
--- a/src/shared/components/SubmissionManagement/Submission/index.jsx
+++ b/src/shared/components/SubmissionManagement/Submission/index.jsx
@@ -43,11 +43,11 @@ export default function Submission(props) {
 
   // Determine if a challenge is for Topcrowd so we can edit the UI accordingly
   let isTopCrowdChallenge = false;
-  const isTopCrowdChallengeData = _.find(challenge.metadata, { name: 'is_platform' });
-  if (isTopCrowdChallengeData) {
-    isTopCrowdChallenge = isTopCrowdChallengeData.value;
-  } else {
-    isTopCrowdChallenge = false;
+  if (challenge) {
+    const isTopCrowdChallengeData = _.find(challenge.metadata, { name: 'is_platform' });
+    if (isTopCrowdChallengeData) {
+      isTopCrowdChallenge = isTopCrowdChallengeData.value;
+    }
   }
 
   return (

From 4b7d1f93a7ade188c7de275b64912787aa5a05b5 Mon Sep 17 00:00:00 2001
From: Justin Gasper <jmgasper@gmail.com>
Date: Sun, 7 Apr 2024 03:08:22 +0000
Subject: [PATCH 4/7] Fix for TOP-611 / existing bug with showing submission
 dates when logged out

---
 .../challenge-detail/Registrants/index.jsx    | 20 ++++++++++++++++++-
 .../containers/challenge-detail/index.jsx     |  1 +
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/src/shared/components/challenge-detail/Registrants/index.jsx b/src/shared/components/challenge-detail/Registrants/index.jsx
index a16668d4e9..5b85305731 100644
--- a/src/shared/components/challenge-detail/Registrants/index.jsx
+++ b/src/shared/components/challenge-detail/Registrants/index.jsx
@@ -128,6 +128,19 @@ export default class Registrants extends React.Component {
     return final;
   }
 
+  /**
+    * Get the submission date of a registrant (used when viewing the registrants tab anonymously)
+    * @param {Object} registrant the registrant to return the submission date for
+    */
+  getSubmissionDate(registrant, statisticsData) {
+    let submissionDate;
+    const statistic = (statisticsData || []).find(x => x.handle === registrant.memberHandle)
+    if(statistic && statistic.submissions && statistic.submissions.length>0){
+      submissionDate = statistic.submissions.sort()[0].created;
+    }
+    return submissionDate;
+  }
+
   /**
     * Check if it have flag for first try
     * @param {Object} registrant registrant info
@@ -244,6 +257,7 @@ export default class Registrants extends React.Component {
       checkpointResults,
       results,
       onSortChange,
+      statisticsData,
     } = this.props;
     const {
       prizeSets,
@@ -413,7 +427,10 @@ export default class Registrants extends React.Component {
                if (checkpoint) {
                  checkpoint = formatDate(checkpoint);
                }
-               const final = this.getFinal(r);
+               let final = this.getFinal(r);
+               if(!final){
+                final = this.getSubmissionDate(r, statisticsData);
+               }
 
                return (
                  <div styleName="row" key={r.memberHandle} role="row">
@@ -523,6 +540,7 @@ Registrants.propTypes = {
     type: PT.string,
     track: PT.string,
   }).isRequired,
+  statisticsData: PT.arrayOf(PT.shape()),
   results: PT.arrayOf(PT.shape()),
   checkpointResults: PT.shape(),
   registrants: PT.arrayOf(PT.shape()),
diff --git a/src/shared/containers/challenge-detail/index.jsx b/src/shared/containers/challenge-detail/index.jsx
index ad625ac2ad..60f6065ef2 100644
--- a/src/shared/containers/challenge-detail/index.jsx
+++ b/src/shared/containers/challenge-detail/index.jsx
@@ -565,6 +565,7 @@ class ChallengeDetailPageContainer extends React.Component {
                   )
                 }
                 results={results2}
+                statisticsData={statisticsData}
                 registrantsSort={registrantsSort}
                 notFoundCountryFlagUrl={notFoundCountryFlagUrl}
                 onGetFlagImageFail={(countryInfo) => {

From ab42859a1b8ce60c3b26fa8a99aa2eb1122d5f4a Mon Sep 17 00:00:00 2001
From: Justin Gasper <jmgasper@gmail.com>
Date: Sun, 7 Apr 2024 03:25:51 +0000
Subject: [PATCH 5/7] Lint

---
 .../challenge-detail/Registrants/index.jsx          | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/shared/components/challenge-detail/Registrants/index.jsx b/src/shared/components/challenge-detail/Registrants/index.jsx
index 5b85305731..37629fb6c1 100644
--- a/src/shared/components/challenge-detail/Registrants/index.jsx
+++ b/src/shared/components/challenge-detail/Registrants/index.jsx
@@ -58,6 +58,7 @@ export default class Registrants extends React.Component {
 
     this.getCheckPoint = this.getCheckPoint.bind(this);
     this.getCheckPointDate = this.getCheckPointDate.bind(this);
+    this.getSubmissionDate = this.getSubmissionDate.bind(this);
     this.getFlagFirstTry = this.getFlagFirstTry.bind(this);
     this.sortRegistrants = this.sortRegistrants.bind(this);
     this.getRegistrantsSortParam = this.getRegistrantsSortParam.bind(this);
@@ -132,10 +133,10 @@ export default class Registrants extends React.Component {
     * Get the submission date of a registrant (used when viewing the registrants tab anonymously)
     * @param {Object} registrant the registrant to return the submission date for
     */
-  getSubmissionDate(registrant, statisticsData) {
+  static getSubmissionDate(registrant, data) {
     let submissionDate;
-    const statistic = (statisticsData || []).find(x => x.handle === registrant.memberHandle)
-    if(statistic && statistic.submissions && statistic.submissions.length>0){
+    const statistic = (data || []).find(x => x.handle === registrant.memberHandle);
+    if (statistic && statistic.submissions && statistic.submissions.length > 0) {
       submissionDate = statistic.submissions.sort()[0].created;
     }
     return submissionDate;
@@ -428,8 +429,8 @@ export default class Registrants extends React.Component {
                  checkpoint = formatDate(checkpoint);
                }
                let final = this.getFinal(r);
-               if(!final){
-                final = this.getSubmissionDate(r, statisticsData);
+               if (!final) {
+                 final = this.getSubmissionDate(r, statisticsData);
                }
 
                return (
@@ -540,7 +541,7 @@ Registrants.propTypes = {
     type: PT.string,
     track: PT.string,
   }).isRequired,
-  statisticsData: PT.arrayOf(PT.shape()),
+  statisticsData: PT.arrayOf(PT.shape()).isRequired,
   results: PT.arrayOf(PT.shape()),
   checkpointResults: PT.shape(),
   registrants: PT.arrayOf(PT.shape()),

From c81c9f08820ebc2cc708990108198652cfbf40c0 Mon Sep 17 00:00:00 2001
From: Justin Gasper <jmgasper@gmail.com>
Date: Sun, 7 Apr 2024 03:37:56 +0000
Subject: [PATCH 6/7] Fix bug after lint fixes

---
 src/shared/components/challenge-detail/Registrants/index.jsx | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/shared/components/challenge-detail/Registrants/index.jsx b/src/shared/components/challenge-detail/Registrants/index.jsx
index 37629fb6c1..1f31d3e432 100644
--- a/src/shared/components/challenge-detail/Registrants/index.jsx
+++ b/src/shared/components/challenge-detail/Registrants/index.jsx
@@ -58,7 +58,6 @@ export default class Registrants extends React.Component {
 
     this.getCheckPoint = this.getCheckPoint.bind(this);
     this.getCheckPointDate = this.getCheckPointDate.bind(this);
-    this.getSubmissionDate = this.getSubmissionDate.bind(this);
     this.getFlagFirstTry = this.getFlagFirstTry.bind(this);
     this.sortRegistrants = this.sortRegistrants.bind(this);
     this.getRegistrantsSortParam = this.getRegistrantsSortParam.bind(this);

From f77c8754ca7351d4b74ed2179a20e85c36b997f1 Mon Sep 17 00:00:00 2001
From: Justin Gasper <jmgasper@gmail.com>
Date: Sun, 7 Apr 2024 04:09:45 +0000
Subject: [PATCH 7/7] Bug fixes after lint made me break things

---
 .../challenge-detail/Registrants/index.jsx           | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/shared/components/challenge-detail/Registrants/index.jsx b/src/shared/components/challenge-detail/Registrants/index.jsx
index 1f31d3e432..0d238d2cd1 100644
--- a/src/shared/components/challenge-detail/Registrants/index.jsx
+++ b/src/shared/components/challenge-detail/Registrants/index.jsx
@@ -58,6 +58,7 @@ export default class Registrants extends React.Component {
 
     this.getCheckPoint = this.getCheckPoint.bind(this);
     this.getCheckPointDate = this.getCheckPointDate.bind(this);
+    this.getSubmissionDate = this.getSubmissionDate.bind(this);
     this.getFlagFirstTry = this.getFlagFirstTry.bind(this);
     this.sortRegistrants = this.sortRegistrants.bind(this);
     this.getRegistrantsSortParam = this.getRegistrantsSortParam.bind(this);
@@ -132,9 +133,13 @@ export default class Registrants extends React.Component {
     * Get the submission date of a registrant (used when viewing the registrants tab anonymously)
     * @param {Object} registrant the registrant to return the submission date for
     */
-  static getSubmissionDate(registrant, data) {
+  getSubmissionDate(registrant) {
+    const {
+      statisticsData,
+    } = this.props;
+    console.log(JSON.stringify(statisticsData, null, 4));
     let submissionDate;
-    const statistic = (data || []).find(x => x.handle === registrant.memberHandle);
+    const statistic = (statisticsData || []).find(x => x.handle === registrant.memberHandle);
     if (statistic && statistic.submissions && statistic.submissions.length > 0) {
       submissionDate = statistic.submissions.sort()[0].created;
     }
@@ -257,7 +262,6 @@ export default class Registrants extends React.Component {
       checkpointResults,
       results,
       onSortChange,
-      statisticsData,
     } = this.props;
     const {
       prizeSets,
@@ -429,7 +433,7 @@ export default class Registrants extends React.Component {
                }
                let final = this.getFinal(r);
                if (!final) {
-                 final = this.getSubmissionDate(r, statisticsData);
+                 final = this.getSubmissionDate(r);
                }
 
                return (