From 846260c5f7a381d58becb751d2e465a672187887 Mon Sep 17 00:00:00 2001 From: "helder.junior" Date: Tue, 13 Aug 2024 13:20:08 -0300 Subject: [PATCH] Debugging client metrics --- client/client.go | 3 ++- config/local.yaml | 2 +- metrics/metrics.go | 28 +++++++++++++++------------- server/config/local.yaml | 2 +- 4 files changed, 19 insertions(+), 16 deletions(-) diff --git a/client/client.go b/client/client.go index 1d07cc5..3ea82c2 100644 --- a/client/client.go +++ b/client/client.go @@ -113,8 +113,9 @@ func (c *Client) newGRPCClient( "serverAddress": c.serverAddress, "async": async, }) - + c.logger.Infoln("Registering events gateway metrics...") err := metrics.RegisterMetrics(configPrefix, c.config) + c.logger.Infoln("Events gateway metrics registered.") if err != nil { return nil, err } diff --git a/config/local.yaml b/config/local.yaml index 6cef023..8d13b0a 100644 --- a/config/local.yaml +++ b/config/local.yaml @@ -20,7 +20,7 @@ client: timeout: 500ms loadtestclient: duration: 10s - threads: 10 + threads: 1 randSleepCeilingMs: 500 randPropsSize: small # small, medium, large, jumbo prometheus: diff --git a/metrics/metrics.go b/metrics/metrics.go index 5769ce4..ffb5fb8 100644 --- a/metrics/metrics.go +++ b/metrics/metrics.go @@ -23,7 +23,6 @@ package metrics import ( - "errors" "github.com/prometheus/client_golang/prometheus" "github.com/spf13/viper" ) @@ -81,22 +80,25 @@ var ( // it only returns an error if the metric wasn't already registered and there was an // actual error registering it. func RegisterMetrics(configPrefix string, config *viper.Viper) error { - collectors := []prometheus.Collector{ + + //collectors := []prometheus.Collector{ + // + //} + prometheus.MustRegister( ClientRequestsResponseTime, ClientRequestsSuccessCounter, ClientRequestsFailureCounter, - AsyncClientRequestsDroppedCounter, - } + AsyncClientRequestsDroppedCounter) - for _, collector := range collectors { - err := prometheus.Register(collector) - if err != nil { - var alreadyRegisteredError prometheus.AlreadyRegisteredError - if !errors.As(err, &alreadyRegisteredError) { - return err - } - } - } + //for _, collector := range collectors { + // err := prometheus.MustRegister() + // if err != nil { + // var alreadyRegisteredError prometheus.AlreadyRegisteredError + // if !errors.As(err, &alreadyRegisteredError) { + // return err + // } + // } + //} return nil } diff --git a/server/config/local.yaml b/server/config/local.yaml index 9c3d48e..2c9291b 100644 --- a/server/config/local.yaml +++ b/server/config/local.yaml @@ -28,7 +28,7 @@ pprof: enabled: true address: localhost:6060 otlp: - enabled: true + enabled: false serviceName: "eventsgateway-server" traceSamplingRatio: 0.2 jaegerHost: jaeger