Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask the designer how to implement share links in blog posts #29

Closed
josecelano opened this issue Sep 24, 2024 · 2 comments · Fixed by #50
Closed

Ask the designer how to implement share links in blog posts #29

josecelano opened this issue Sep 24, 2024 · 2 comments · Fixed by #50
Assignees
@grmbyrn
Labels
- User - Enjoyable to Use our Software UI User Interface

Comments

@josecelano
Copy link
Member

Current:

image

Expected:

It hasn't been included yet in the original design:

image
@josecelano
Copy link
Member Author

Fer has added the design to Figma:

image

cc @grmbyrn

@grmbyrn grmbyrn mentioned this issue Sep 25, 2024
Merged
@josecelano
Copy link
Member Author

Hi @grmbyrn, in your implementation, the icon color is different. And the font is larger.

image

josecelano added a commit that referenced this issue Sep 25, 2024
@josecelano
Merge #44: fix issues with v2
aec6ce6 
19437dd Fix conflict issues (Graeme Byrne)
5c2e1df fix issues with v2 (Graeme Byrne)

Pull request description:

  * moved posts for index and tracker into `TorrustIndexPost.svelte` and `TorrustTrackerPost.svelte`
  * [Key features list width should be 100% #6](#6)
  * [Review design for table of contents #8](#8)
  * [Minor bugs in homepage #12](#12)
  * [Homepage cards don't have the same padding as design #25](#25)
  * [Top menu padding is not the same as the design #26](#26)
  * [Related Post section does not look like the standard blog post list #27](#27)
  * [Ask the designer how we should implement navigation between blog posts #28](#28)
  * [Ask the designer how to implement share links in blog posts #29](#29)
  * [Remove # prefix from titles #30](#30)
  * [Ask the designer how to implement highlighted terms or sentences in markdown #36](#36)
  * [Font style in feature card is not the same as in the original design #43](#43)

ACKs for top commit:
  josecelano:
    ACK 19437dd

Tree-SHA512: a60b8ee60753f8517ddd53ae1073d97b481b9badbc75938f364b0c239ab561a6b2eece7d01f5c4ff4e97af9804facfb04e8266377a32ce4a27c531dcf5263044
@josecelano josecelano added - User - Enjoyable to Use our Software UI User Interface labels Sep 25, 2024
@grmbyrn grmbyrn mentioned this issue Sep 27, 2024
Merged
@josecelano josecelano linked a pull request Sep 27, 2024 that will close this issue
fix v2 issues #50
Merged
josecelano added a commit that referenced this issue Sep 27, 2024
@josecelano
Merge #50: fix v2 issues
06efe08 
cbe642e fix v2 issues (Graeme Byrne)

Pull request description:

  * change from using `window` in `TableOfContents` to using `IntersectionObserver`
  * [fielename prop in <CodeBlock> component should be optional #49](#49)
  * [Normal links don't have any special style #48](#48)
  * [Ask the designer how to implement a link inside a key feature card #42](#42)
  * [Blog post tags style is not the same as the design #38](#38)
  * [Ask the designer how to implement html lists #37](#37)
  * [Font size for table of contents is not as the design #31](#31)
  * [Ask the designer how to implement share links in blog posts #29](#29)
  * [Related Post section does not look like the standard blog post list #27](#27)
  * [Top menu padding is not the same as the design #26](#26)
  * [Key features list width should be 100% #6](#6)

ACKs for top commit:
  josecelano:
    ACK cbe642e

Tree-SHA512: 1b6df7281d9b9f0f88555874aec76fc20d2a73b098ef9112952b47fc916981c26ec63ee1197c21c1c75fd9db6c1ea1da453a91142838d11a77656c3845dbbefa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grmbyrn grmbyrn

Labels
- User - Enjoyable to Use our Software UI User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix v2 issues grmbyrn/torrust-website-v2
2 participants
@josecelano @grmbyrn