Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask the designer how to implement a link inside a key feature card #42

Closed
josecelano opened this issue Sep 25, 2024 · 4 comments · Fixed by #85
Closed

Ask the designer how to implement a link inside a key feature card #42

josecelano opened this issue Sep 25, 2024 · 4 comments · Fixed by #85
Assignees
@grmbyrn
Labels
- User - Enjoyable to Use our Software UI User Interface
Milestone
v3.0.0

Comments

@josecelano
Copy link
Member

josecelano commented Sep 25, 2024 •
edited
Loading

Current:

image

Expected:

Not included in design.
@josecelano josecelano mentioned this issue Sep 25, 2024
Closed
2 tasks
@josecelano josecelano added - User - Enjoyable to Use our Software UI User Interface labels Sep 25, 2024
@fvdlc
Copy link
Collaborator

fvdlc commented Sep 26, 2024

I would not link individual elements within the card, but the whole card instead. We can make the border visible while hovering and make the card clickable. Figma example.

@grmbyrn grmbyrn mentioned this issue Sep 27, 2024
Merged
@josecelano
Copy link
Member Author

Hi @grmbyrn, the hover border is 2px

image

josecelano added a commit that referenced this issue Sep 27, 2024
@josecelano
Merge #50: fix v2 issues
06efe08 
cbe642e fix v2 issues (Graeme Byrne)

Pull request description:

  * change from using `window` in `TableOfContents` to using `IntersectionObserver`
  * [fielename prop in <CodeBlock> component should be optional #49](#49)
  * [Normal links don't have any special style #48](#48)
  * [Ask the designer how to implement a link inside a key feature card #42](#42)
  * [Blog post tags style is not the same as the design #38](#38)
  * [Ask the designer how to implement html lists #37](#37)
  * [Font size for table of contents is not as the design #31](#31)
  * [Ask the designer how to implement share links in blog posts #29](#29)
  * [Related Post section does not look like the standard blog post list #27](#27)
  * [Top menu padding is not the same as the design #26](#26)
  * [Key features list width should be 100% #6](#6)

ACKs for top commit:
  josecelano:
    ACK cbe642e

Tree-SHA512: 1b6df7281d9b9f0f88555874aec76fc20d2a73b098ef9112952b47fc916981c26ec63ee1197c21c1c75fd9db6c1ea1da453a91142838d11a77656c3845dbbefa
@josecelano josecelano added this to the v3.0.0 milestone Oct 1, 2024
@grmbyrn grmbyrn mentioned this issue Oct 2, 2024
Merged
@josecelano
Copy link
Member Author

Hi @grmbyrn this is still not working in #68. The link should be the whole card.

josecelano added a commit that referenced this issue Oct 3, 2024
@josecelano
Merge #68: fix issues
4fbfc01 
36e1da4 fix favicon issue (Graeme Byrne)
1ce0e97 fix issues (Graeme Byrne)

Pull request description:

  [Invalid URL: /undefined #5](#5)
  [Missing elements in the new design for blog posts #10](#10)
  [Remove # prefix from table of contents items #33](#33)
  [Missing paragraph separator in About page #34](#34)
  [Ask designer how to implement different types of callouts components #35](#35)
  [Blog post card size is not the same as in the design (full width) #39](#39)
  [Ask the designer how to implement a link inside a key feature card #42](#42)
  [Ask the designer how body content should look for wide screens #46](#46)
  [Homepage hero element is not like the design #51](#51)
  [Blog post footer navigation doesn't change the main image #53](#53)
  [Enable second level of indentation in TableOfContents section #58](#58)
  [Update the favicons #61](#61)
  [First card in key features is not shown #62](#62)

ACKs for top commit:
  josecelano:
    ACK 36e1da4

Tree-SHA512: 3a3665dcbb1a67b34f11ebef3ad7c801203a126219634eeb524c1739268678f3ca17d185e593e4a8e45b958e20d257e5bacb47967a616785c7d72d96cdb41609
@grmbyrn
Copy link
Collaborator

grmbyrn commented Oct 3, 2024

Hi @grmbyrn this is still not working in #68. The link should be the whole card.

Hi @josecelano I had it like that but changed it. I'll change it back to be a link for the whole card.

@grmbyrn grmbyrn mentioned this issue Oct 3, 2024
Merged
@josecelano josecelano linked a pull request Oct 4, 2024 that will close this issue
fix github issues #85
Merged
josecelano added a commit that referenced this issue Oct 4, 2024
@josecelano
Merge #85: fix github issues
93a3e12 
ebca183 fix github issues (Graeme Byrne)

Pull request description:

  * In order to prevent long URLs in links and list items from overflowing the page, add :
  ```
  word-wrap: break-word;
  word-break: break-all;
  overflow-wrap: break-word;
  white-space: normal;
  ```
  * Remove `word-break: break-all;` from links and list items which don't require it.
  * [Highlight ToC #81](#81)
  * [Build error: TypeError: Cannot read properties of undefined (reading 'relatedPosts') #80](#80)
  * [Ask the designer how to implement a link inside a key feature card #42](#42)
  * [Enable second level of indentation in TableOfContents section #58](#58)
  * [v1 error page in v2 #71](#71)
  * [Fake links in homepage #84](#84)

ACKs for top commit:
  josecelano:
    ACK ebca183

Tree-SHA512: 6536a66c42e4876ab6b5aebf7f68405441420eee2b87ff1887ffcbd2a09ac7ed1e588e563075476a2b51f4abe4b046e4947959e0c9f408de99b9057d5aa14f74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grmbyrn grmbyrn

Labels
- User - Enjoyable to Use our Software UI User Interface
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

fix github issues grmbyrn/torrust-website-v2
3 participants
@josecelano @fvdlc @grmbyrn