Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable second level of indentation in TableOfContents section #58

Closed
josecelano opened this issue Sep 30, 2024 · 0 comments · Fixed by #85
Closed

Enable second level of indentation in TableOfContents section #58

josecelano opened this issue Sep 30, 2024 · 0 comments · Fixed by #85
Assignees
Labels
Bug Incorrect Behaviour
Milestone

Comments

@josecelano
Copy link
Member

josecelano commented Sep 30, 2024

Hi @grmbyrn, for the time being, I'm hiding subitems in the TableOfContents because there was not indentation. I stared using <h3> for the new level. We have to implement this option to show second-level items correctly in the table of contents and the text (using different font sizes).

Current:

image

Expected:

image

@josecelano josecelano added the Bug Incorrect Behaviour label Sep 30, 2024
@josecelano josecelano added this to the v3.0.0 milestone Oct 1, 2024
@grmbyrn grmbyrn mentioned this issue Oct 2, 2024
josecelano added a commit that referenced this issue Oct 3, 2024
36e1da4 fix favicon issue (Graeme Byrne)
1ce0e97 fix issues (Graeme Byrne)

Pull request description:

  [Invalid URL: /undefined #5](#5)
  [Missing elements in the new design for blog posts #10](#10)
  [Remove # prefix from table of contents items #33](#33)
  [Missing paragraph separator in About page #34](#34)
  [Ask designer how to implement different types of callouts components #35](#35)
  [Blog post card size is not the same as in the design (full width) #39](#39)
  [Ask the designer how to implement a link inside a key feature card #42](#42)
  [Ask the designer how body content should look for wide screens #46](#46)
  [Homepage hero element is not like the design #51](#51)
  [Blog post footer navigation doesn't change the main image #53](#53)
  [Enable second level of indentation in TableOfContents section #58](#58)
  [Update the favicons #61](#61)
  [First card in key features is not shown #62](#62)

ACKs for top commit:
  josecelano:
    ACK 36e1da4

Tree-SHA512: 3a3665dcbb1a67b34f11ebef3ad7c801203a126219634eeb524c1739268678f3ca17d185e593e4a8e45b958e20d257e5bacb47967a616785c7d72d96cdb41609
@josecelano josecelano linked a pull request Oct 4, 2024 that will close this issue
josecelano added a commit that referenced this issue Oct 4, 2024
ebca183 fix github issues (Graeme Byrne)

Pull request description:

  * In order to prevent long URLs in links and list items from overflowing the page, add :
  ```
  word-wrap: break-word;
  word-break: break-all;
  overflow-wrap: break-word;
  white-space: normal;
  ```
  * Remove `word-break: break-all;` from links and list items which don't require it.
  * [Highlight ToC #81](#81)
  * [Build error: TypeError: Cannot read properties of undefined (reading 'relatedPosts') #80](#80)
  * [Ask the designer how to implement a link inside a key feature card #42](#42)
  * [Enable second level of indentation in TableOfContents section #58](#58)
  * [v1 error page in v2 #71](#71)
  * [Fake links in homepage #84](#84)

ACKs for top commit:
  josecelano:
    ACK ebca183

Tree-SHA512: 6536a66c42e4876ab6b5aebf7f68405441420eee2b87ff1887ffcbd2a09ac7ed1e588e563075476a2b51f4abe4b046e4947959e0c9f408de99b9057d5aa14f74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect Behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants