Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showMultiDay option shows no multi-day events at all #1010

Closed
2 tasks done
jensrossbach opened this issue May 1, 2023 · 18 comments · Fixed by #1143
Closed
2 tasks done

showMultiDay option shows no multi-day events at all #1010

jensrossbach opened this issue May 1, 2023 · 18 comments · Fixed by #1143
Labels
released type/bug Something isn't working

Comments

@jensrossbach
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When I set option showMultiDay to true, multi-day events are not shown at all anymore.

Expected behaviour

I see multi-day events on every day as the option suggests.

Steps To Reproduce

No response

Card Version

7.3.0

Home Assistant Version

2023.4.6

Configuration

- type: custom:atomic-calendar-revive
    entities:
    - entity: calendar.o365_deutsche_feiertage
        name: Feiertage
        color: rgb(220, 0, 80)
        icon: mdi:flag-variant
    - entity: calendar.abfallkalender
        name: Müllabfuhr
        color: rgb(0, 220, 250)
        icon: mdi:trash-can-outline
    - entity: calendar.schulferien
        name: Schulferien
        color: rgb(50, 150, 50)
        icon: mdi:school
    - entity: calendar.o365_geburtstagskalender
        name: Geburtstage
        color: rgb(200, 100, 250)
        icon: mdi:cake-variant
    - entity: calendar.o365_familie
        name: Familie
        color: rgb(0, 160, 255)
        icon: mdi:human-male-female-child
    defaultMode: Calendar
    showLoader: false
    disableEventLink: true
    disableLocationLink: true
    disableCalEventLink: true
    disableCalLocationLink: true
    disableCalLink: true
    calEventTime: true
    showMultiDay: true
    showMultiDayEventParts: true
    fullDayEventText: Ganztägig

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jensrossbach jensrossbach added the type/bug Something isn't working label May 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

Hello @jensrossbach, thank you for your interest in our work!
If this is a bug report, please provide your configuration and any screenshots that would assist troubleshooting, otherwise we can not help you.

@bkr1969
Copy link

bkr1969 commented May 8, 2023

Same problem. Here is my code. Please ignore the -null as that is brought up in another issue.

type: custom:atomic-calendar-revive
name: Calendar Card
entities:
  - null
  - entity: calendar.anylist_meal_plan
    name: Anylist meal plan
    color: grey
    icon: mdi:silverware-fork-knife
  - entity: calendar.ohio_state_buckeyes
    name: Ohio state buckeyes
    icon: mdi:football
    color: maroon
enableModeChange: true
defaultMode: Calendar
calShowDescription: true
showLastCalendarWeek: false
disableCalEventLink: false
disableCalLink: true
firstDayOfWeek: 0
maxDaysToShow: 10
refreshInterval: 60
showDate: true
showRelativeTime: true
showMultiDay: false
hideDuplicates: true
sortByStartTime: true
showCurrentEventLine: true
calEventTime: true
showMonth: true
showFullDayProgress: true
showWeekDay: false
showEventIcon: true
showCalendarName: true
showHiddenText: false
showDatePerEvent: false
disableCalLocationLink: false
showMultiDayEventParts: true
hideFinishedEvents: false
untilText: 'true'

NOTICE: showMultiDay is set to false which causes the first day of event to show up. If set to true, the entire event is missing, including the first day. When set to false, the end time of the multi-day event shows up as the end time on the start date which is really weird since I have an even that starts at 12:00 noon and ends 4 days later at 10:00 am. The start day shows the event time as 12:00 - 10:00.

@marksie1988
Copy link
Collaborator

This issue odd, I have done a test with the exact same config and it works as expected and times show correctly in both instances

Are you using caldav or Google calendar where you see this issue?

@bkr1969
Copy link

bkr1969 commented May 11, 2023

caldav

@marksie1988
Copy link
Collaborator

marksie1988 commented May 12, 2023

Ah ok, caldav support is somewhat limited, I can take a look and see what's happening though, basically caldav managed it's calendars differently with home assistant which causes some problems with entries not working as expected. Hopefully this isn't one of those instances and can be fixed.

I only tested with Google calendar as that is fully supported.

@jensrossbach
Copy link
Author

This issue odd, I have done a test with the exact same config and it works as expected and times show correctly in both instances

Are you using caldav or Google calendar where you see this issue?

I'm using calendars from the O365 integration and calendars from the ICS integration. The issue happens for both type of calendars.

@bkr1969
Copy link

bkr1969 commented Jun 6, 2023

So the caldav events spanning multiple days work fine on the standard HA calendar. There has to be something in this integration that is buggy. Should be an easy fix since it works elsewhere.

@marksie1988
Copy link
Collaborator

marksie1988 commented Sep 5, 2023

Hey guys, I've done some work on showMultiDay please update to v7.7.0 and let me know if this resolves the issue you see, if not please provide some example events that cause the issue so I can do a bit of testing. Thanks.

@bkr1969
Copy link

bkr1969 commented Sep 5, 2023

Will this affect past events because I just updated with no change. I can try a new event if necessary.

@marksie1988
Copy link
Collaborator

Will this affect past events because I just updated with no change. I can try a new event if necessary.

It should work on past events too, but ensure you see v7.7.0 in the developer console for atomic calendar to make sure it's not cached the old version.

@bkr1969
Copy link

bkr1969 commented Sep 5, 2023

Version confirmed and HA completely restarted after update. Same behavior, setting show multi day to true erases the entire event and false shows start and end time on the start day.

@marksie1988
Copy link
Collaborator

marksie1988 commented Sep 5, 2023

Could you give an example start and end time / date for an event this happens on?

I have tested and mine are showing fine so maybe it's something specific I'm missing.

@bkr1969
Copy link

bkr1969 commented Sep 5, 2023

Well, I had an event starting on September 1 at 12:00 and ending on September 4 at 10:00. If I set "Show Multi Day" to false, the event shows up on the 1st as 12:00 to 10:00. If I set to true, the even doesn't show at all.

image

@bkr1969
Copy link

bkr1969 commented Sep 5, 2023

I'm expecting something like this:
image

Notice the Family Camp extending from Friday to Monday.

@bkr1969
Copy link

bkr1969 commented Sep 5, 2023

Also, to note again, I am using Apple Calender via iCal.

@marksie1988
Copy link
Collaborator

Ok So i see this issue now and found another issue too.

When showMultiDay is set the following happens:

Calendar Mode

  • Event does not show if its multi day
  • All day single day event shows from 00:00 to 00:00 rather than as all day

Event Mode

  • Event shows incorrect times if it is the last day, last day should always start at 00:00
  • Display parts will display 1/3 even on the last day which should be 3/3
  • "isLastDay" showing as undefined on last day of a multi day event
  • All day single day event shows from 00:00 to 00:00 rather than as all day

I will start to work on a solution for this and get a bugfix out soon.

@marksie1988 marksie1988 mentioned this issue Sep 12, 2023
10 tasks
@github-actions
Copy link

🎉 This issue has been resolved in version 7.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bkr1969
Copy link

bkr1969 commented Sep 12, 2023

This is not fixed. I re-downloaded the latest version, refreshed and even re-started HA. Multiday events still only show on the start day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants