Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Svelte #16

Open
raduab opened this issue Dec 21, 2020 · 5 comments
Open

Support Svelte #16

raduab opened this issue Dec 21, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@raduab
Copy link

raduab commented Dec 21, 2020

Do you have plans to Support Svelte language?

@raduab raduab added the enhancement New feature or request label Dec 21, 2020
@thefrana
Copy link

thefrana commented Jan 19, 2021

Well, there is an issue #4 which said it should be working. Also there is commit saying "add svelte support" two moths ago, but one month ago, support for Svelte was removed. Why? @acidic9

@tqwewe
Copy link
Owner

tqwewe commented Jan 20, 2021

Hi @Lukeeno and @raduab

I had to remove the implementation of svelte support for now because it was causing some unpredictable bugs i couldn't solve which was affecting people who weren't even using Svelte.

I'd love to tackle this issue again sometime soon but I don't have a whole lot of time recently.

The prettier API for plugins such as this is so terrible and the way this plugin works is by overriding the html/JavaScript/... parsers provided by prettier.
It would be much more desirable to extend rather than override, but it is not possible currently and I don't think prettier have plans for this too.

I'm happy for anyone to submit PR's.. unfortunately I don't have so much time to fix all the issues myself these days and I truly apologise. I hope I can be more active in the future!

@raduab
Copy link
Author

raduab commented Mar 2, 2021

maybe https://github.com/sveltejs/prettier-plugin-svelte can be an inspiration?

@ebeloded
Copy link

@acidic9 any chance you can take another stab at adding Svelte support? 🙏🏻

@raduab
Copy link
Author

raduab commented Jun 28, 2021

I don't know but this Code extension might help also: https://github.com/heybourn/headwind

If I want to implement this myself, would you please give me some pointers on what should I begin with? Also, any other info to get me up to speed, maybe a short list of tasks that I should follow. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants