Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using expo-random as the peer dep so that ejecting from an Expo app isn't required #45

Open
pcowgill opened this issue Dec 30, 2019 · 5 comments

Comments

@pcowgill
Copy link
Contributor

Consider using expo-random as the peer dep rather than react-native-randombytes so that ejecting from an Expo app isn't required in order to use react-native-crypto.

This would involve a polyfill that matches the node core crypto.randomBytes API exactly but uses the expo-random methods internally rather than react-native-randombytes methods.

expo-random works in both "managed" and "bare" Expo apps as well as vanilla React Native apps (Source)

@mvayngrib
Copy link
Member

from expo-random:

For bare React Native projects, you must ensure that you have installed and configured the react-native-unimodules package before continuing.

this in addition to the requirement for an additional polyfill makes it pretty unattractive

@pcowgill
Copy link
Contributor Author

pcowgill commented Jan 5, 2020

this in addition to the requirement for an additional polyfill makes it pretty unattractive

@mvayngrib What in particular is unattractive about react-native-unimodules?

@mvayngrib
Copy link
Member

@ammedinap93
Copy link

So, if I am using Expo Client I cannot use this library. Is this correct?

@mvayngrib
Copy link
Member

@ammedinap93 yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants