Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation bar spacing seems uneven #289

Open
1 task done
Jackenmen opened this issue Jan 14, 2025 · 3 comments
Open
1 task done

Navigation bar spacing seems uneven #289

Jackenmen opened this issue Jan 14, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request ux User experience improvements, usability enhancements, and interaction design

Comments

@Jackenmen
Copy link
Contributor

Jackenmen commented Jan 14, 2025

Code of Conduct

Where did you encounter the bug?

Any page since the navigation bar is always present at the bottom in the mobile layout.

Please describe the bug below

The current spacing used for the navigation bar can cause issues for slightly longer translations in the first and last buttons. While the text-overflow set to ellipsis prevents overspill, it would be great, if the buttons near the edges were closer to the centre to allow for a bit longer labels. As far as I can tell, the first and second buttons have similarly long labels but the free space for the latter would have allowed for a longer label, while the first button's label would have been cut off by that point.

The problem is best seen in Polish:

Polish page

Screenshot_20250114_172538_Chrome

but in Deutsch, there's also a slight issue with how "Wunschliste" eliminates the margin entirely:

Deutsch page

Screenshot_20250114_172526_Chrome

Perhaps the idea here would be to make it so the items are evenly spaced over the available space as even in English, you can see the uneven margins on the left and right edge due to "Watchlist" being a longer word than "Home":

English page

Screenshot_20250114_172511_Chrome

Additional information

No response

@vladjerca vladjerca added enhancement New feature or request ux User experience improvements, usability enhancements, and interaction design labels Jan 14, 2025
@vladjerca
Copy link
Collaborator

Yeah, this as an interesting once since if a text doesn't fill-in the full width of the action button it will make it seem as if they're not visually equal.

One quick fix would be to remove labels completely 😅😂

@anodpixels thoughts?

@anodpixels
Copy link
Collaborator

Really good catch @Jackenmen
Thanks for pointing this out to us and for the recommendation.
2 quick questions here for you as a user of Trakt:

  1. Will the fact that the buttons icons might move horizontally based on the language bother you more than
  2. Having the buttons label shortened by "Wunsch..." ? Will this give you enough context?

Also we will look more into supporting more and more languages, interface-wise as we develop more our design system.

@Jackenmen
Copy link
Contributor Author

Number 2 is how it works today - I think it can be non-obvious what shortened word means, depending on the language. As for 1, I don't think it would bother me, if the button alignment was different between languages as it's not like I'm going to change language regularly (outside of making issues here :)). Personally I will probably continue to use English version of the site but my mom is using it in Polish so I'm hoping to improve situation for that language as well which is why I provided translations + made a bunch of issues (and one discussion).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux User experience improvements, usability enhancements, and interaction design
Projects
None yet
Development

No branches or pull requests

3 participants