You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In v0.24.1 for #59 (f1f42c1) the library loading was changed to use SymbolLookup.loaderLookup() as fallback if SymbolLookup.libraryLookup(library, ...) fails.
The disadvantage is that when users don't actually want to use SymbolLookup.loaderLookup(), the library loading silently fails and afterwards they encounter cryptic "UnsatisfiedLinkError: unresolved symbol: ts_..." errors.
(probably related: #80)
Now that #61 added support for custom library loading, would it make sense to make usage of SymbolLookup.loaderLookup() a deliberate opt-in decision of the user, by implementing a NativeLibraryLookup? For example:
Then for all users who don't want to rely on this, if no NativeLibraryLookup implementation has been registered and SymbolLookup.libraryLookup(...) fails, library loading could fail fast.
In that case the package-info.java documentation would have to be updated again, mentioning this possibility to use SymbolLookup.loaderLookup() with NativeLibraryLookup.
This is just an idea though; the disadvantage would be that for users who do want to use SymbolLookup.loaderLookup() it would be a bit more cumbersome.
The text was updated successfully, but these errors were encountered:
In v0.24.1 for #59 (f1f42c1) the library loading was changed to use
SymbolLookup.loaderLookup()
as fallback ifSymbolLookup.libraryLookup(library, ...)
fails.The disadvantage is that when users don't actually want to use
SymbolLookup.loaderLookup()
, the library loading silently fails and afterwards they encounter cryptic "UnsatisfiedLinkError: unresolved symbol: ts_..." errors.(probably related: #80)
Now that #61 added support for custom library loading, would it make sense to make usage of
SymbolLookup.loaderLookup()
a deliberate opt-in decision of the user, by implementing aNativeLibraryLookup
? For example:Then for all users who don't want to rely on this, if no
NativeLibraryLookup
implementation has been registered andSymbolLookup.libraryLookup(...)
fails, library loading could fail fast.In that case the
package-info.java
documentation would have to be updated again, mentioning this possibility to useSymbolLookup.loaderLookup()
withNativeLibraryLookup
.This is just an idea though; the disadvantage would be that for users who do want to use
SymbolLookup.loaderLookup()
it would be a bit more cumbersome.The text was updated successfully, but these errors were encountered: