Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failing since last merge #252

Closed
froozeify opened this issue Dec 6, 2020 · 1 comment
Closed

Test failing since last merge #252

froozeify opened this issue Dec 6, 2020 · 1 comment

Comments

@froozeify
Copy link

I've saw that the test keep failing since the last merge.

Here is the cause I could find in the logs

1) Trikoder\Bundle\OAuth2Bundle\Tests\Integration\AuthorizationServerTest::testValidClientCredentialsGrantWithInheritedScope
Undefined index: access_token

/app/src/Tests/Integration/AuthorizationServerTest.php:238

2) Trikoder\Bundle\OAuth2Bundle\Tests\Integration\AuthorizationServerTest::testValidClientCredentialsGrantWithRequestedScope
Undefined index: access_token

/app/src/Tests/Integration/AuthorizationServerTest.php:272

--

There was 1 failure:

1) Trikoder\Bundle\OAuth2Bundle\Tests\Integration\AuthorizationServerTest::testRestrictedScopeClient
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'invalid_scope'
+'invalid_client'

/app/src/Tests/Integration/AuthorizationServerTest.php:131

My dev environment is not operational to fix those errors (don't have installed ext-timecop and ext-xdebug that are required in the dev dependencies...).

If someone could fix this that'll be great :-) Otherwise I'll do it, but I won't be able to do it until a long time (busy working and also busy with my other PR ;-) )

@froozeify
Copy link
Author

Seems it fixed themselves in my PR, didn't change a thing about it weird 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant