Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Mobile" navigation does not show up in a child theme #6

Open
aoloe opened this issue Nov 11, 2018 · 4 comments
Open

"Mobile" navigation does not show up in a child theme #6

aoloe opened this issue Nov 11, 2018 · 4 comments

Comments

@aoloe
Copy link

aoloe commented Nov 11, 2018

I have extended the bootstrap4 theme.

It does work, but the "Mobile" navigation is not displayed, when the page width is shrinked.

It does show up, when I directly use the bootstrap4 theme.
The "normal" navigation is displayed when the window is wide enough.

I've done a few small changes to the body and navigation partials, so i tried to rename the templates folder to avoid grav from finding the new partials: the navigation does not show up either.

@aoloe
Copy link
Author

aoloe commented Nov 11, 2018

Ok, nevermind, I've found the culprit: i was missing a use at the top of my child theme .php file...
Sorry for the noise.

@aoloe aoloe closed this as completed Nov 11, 2018
@aoloe aoloe reopened this Nov 11, 2018
@aoloe
Copy link
Author

aoloe commented Nov 11, 2018

Oops... I picked the wrong sub-theme... I still have the issue with the one which is based on bs4...

@aoloe
Copy link
Author

aoloe commented Nov 11, 2018

bs4

@aoloe
Copy link
Author

aoloe commented Nov 13, 2018

ok, i could find out how to get it to work.

i had to copy most of the content of the blueprint.yaml and bootstrap4.yaml files into my own file.

the issue seems to be related to a missing value "light" which made a class name invalid and screwed the button detection.

i think you should fix that and do something sane by default, if that value is missing.

ping me if you need more infos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant