Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: RequestLoggerController concurrency errors #165

Open
mosiac1 opened this issue Jan 17, 2025 · 0 comments
Open

Bug: RequestLoggerController concurrency errors #165

mosiac1 opened this issue Jan 17, 2025 · 0 comments

Comments

@mosiac1
Copy link
Contributor

mosiac1 commented Jan 17, 2025

RequestLoggerController uses EvictingQueue from Guava, which is not thread-safe, so you end up with errors such as:

java.util.NoSuchElementException
	at java.base/java.util.ArrayDeque.removeFirst(ArrayDeque.java:361)
	at java.base/java.util.ArrayDeque.remove(ArrayDeque.java:522)
	at com.google.common.collect.EvictingQueue.add(EvictingQueue.java:111)
	at io.trino.aws.proxy.server.rest.RequestLoggerController.logAndClear(RequestLoggerController.java:307)

Which are likely caused by the queue going into a bad state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mosiac1