Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customisable API path #57

Closed
vagaerg opened this issue Jun 6, 2024 · 0 comments · Fixed by #75
Closed

Customisable API path #57

vagaerg opened this issue Jun 6, 2024 · 0 comments · Fixed by #75
Assignees
@vagaerg

Comments

@vagaerg
Copy link
Member

vagaerg commented Jun 6, 2024

This is tangentially related to #23 as it also deals with configuration
The API path for the S3 resource and the STS resource is hardcoded: https://github.com/trinodb/s3-proxy/blob/83e31e95311a09923beff7b332797fb76e123bcd/trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/TrinoS3ProxyResource.java#L34

We should be able to configure it so the proxy could live at the root if needed, or under different paths.
@vagaerg vagaerg self-assigned this Jun 6, 2024
vagaerg added a commit to vagaerg/s3-proxy that referenced this issue Jun 20, 2024
@vagaerg
Support custom prefixes for S3 and STS
adc74db 
Closes trinodb#57
vagaerg added a commit to vagaerg/s3-proxy that referenced this issue Jun 20, 2024
@vagaerg
Support custom prefixes for S3 and STS
c6dacca 
Closes trinodb#57
vagaerg added a commit to vagaerg/s3-proxy that referenced this issue Jun 20, 2024
@vagaerg
Support custom prefixes for S3 and STS
4ebd242 
Closes trinodb#57
@vagaerg vagaerg mentioned this issue Jun 20, 2024
Merged
vagaerg added a commit to vagaerg/s3-proxy that referenced this issue Jun 20, 2024
@vagaerg
Support custom prefixes for S3 and STS
e34a0df 
Closes trinodb#57
vagaerg added a commit to vagaerg/s3-proxy that referenced this issue Jun 20, 2024
@vagaerg
Support custom prefixes for S3 and STS
54ae608 
Closes trinodb#57
vagaerg added a commit to vagaerg/s3-proxy that referenced this issue Jun 20, 2024
@vagaerg
Support custom prefixes for S3 and STS
a46893d 
Closes trinodb#57
vagaerg added a commit to vagaerg/s3-proxy that referenced this issue Jun 20, 2024
@vagaerg
Support custom prefixes for S3 and STS
ffe546e 
Closes trinodb#57
vagaerg added a commit to vagaerg/s3-proxy that referenced this issue Jun 20, 2024
@vagaerg
Support custom prefixes for S3 and STS
2ec2f45 
Closes trinodb#57
vagaerg added a commit that referenced this issue Jun 20, 2024
@vagaerg
Support custom prefixes for S3 and STS (#75)
406ddc0 
Closes #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vagaerg vagaerg

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support custom prefixes for S3 and STS vagaerg/s3-proxy
1 participant
@vagaerg