Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated settings from gateway config #296

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

oneonestar
Copy link
Member

Remove HaGatewayProviderModule, ActiveClusterMonitor, ClusterStateListenerModule,
and ClusterStatsMonitorModule from Trino Gateway config file.
Gateway loads fundamental modules by default after trinodb/trino-gateway#597.
This PR should be merged together with Trino Gateway 14 upgrade.

@cla-bot cla-bot bot added the cla-signed label Jan 27, 2025
@mosabua mosabua requested a review from nineinchnick January 27, 2025 17:16
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I think we can merge now .. we wont cut a 13.x chart .. and are working towards Trino Gateway and the upstream PR is merged.

@mosabua
Copy link
Member

mosabua commented Jan 27, 2025

Also @willmostly .. thoughts?

@nineinchnick
Copy link
Member

We can't merge this since the CI is red.

@mosabua
Copy link
Member

mosabua commented Jan 27, 2025

We can't merge this since the CI is red.

Fair.. so it means we have to merge it after the cut Trino Gateway 14 and publish the container .. but before we get this chart released .. I will keep that in mind ..

@mosabua mosabua merged commit 348a57a into trinodb:main Feb 14, 2025
9 of 10 checks passed
@mosabua mosabua added the breaking-change Potentially breaking changes that require user action. Will be highlighted in release notes. label Feb 14, 2025
@nineinchnick
Copy link
Member

@mosabua please don't merge PRs with red CI, it should have been re-run. If you wanted to merge this before #289, to be included in the 1.14.0 release of the Chart, the Gateway version should have been bumped separately, before bumping the chart version. This is to avoid releasing patch versions of the chart if anything goes wrong.

@nineinchnick
Copy link
Member

@mosabua
Copy link
Member

mosabua commented Feb 18, 2025

Ok.. sounds good.. It was green on the branch builds and only turned red after the merge. So I am not sure what really happened.

@oneonestar oneonestar deleted the ypoon/gateway_config branch February 19, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Potentially breaking changes that require user action. Will be highlighted in release notes. cla-signed
Development

Successfully merging this pull request may close these issues.

3 participants