-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated settings from gateway config #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and I think we can merge now .. we wont cut a 13.x chart .. and are working towards Trino Gateway and the upstream PR is merged.
Also @willmostly .. thoughts? |
We can't merge this since the CI is red. |
Fair.. so it means we have to merge it after the cut Trino Gateway 14 and publish the container .. but before we get this chart released .. I will keep that in mind .. |
@mosabua please don't merge PRs with red CI, it should have been re-run. If you wanted to merge this before #289, to be included in the 1.14.0 release of the Chart, the Gateway version should have been bumped separately, before bumping the chart version. This is to avoid releasing patch versions of the chart if anything goes wrong. |
Master is red now: https://github.com/trinodb/charts/actions/runs/13338304971 |
Ok.. sounds good.. It was green on the branch builds and only turned red after the merge. So I am not sure what really happened. |
Remove
HaGatewayProviderModule
,ActiveClusterMonitor
,ClusterStateListenerModule
,and
ClusterStatsMonitorModule
from Trino Gateway config file.Gateway loads fundamental modules by default after trinodb/trino-gateway#597.
This PR should be merged together with Trino Gateway 14 upgrade.