From c7acd17f27328e63a010594266b1025bc035ec4b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Wa=C5=9B?= Date: Sun, 12 Nov 2023 15:53:19 +0100 Subject: [PATCH] Fix showing connection errors --- src/datasource.test.ts | 4 ++-- src/datasource.ts | 7 +++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/datasource.test.ts b/src/datasource.test.ts index dc7434f..54c0367 100644 --- a/src/datasource.test.ts +++ b/src/datasource.test.ts @@ -54,8 +54,8 @@ describe('Trino datasource', () => { const ds = new DataSource({ name: '', id: 0, jsonData: {} } as any); const result = await ds.testDatasource(); - expect(result.status).toEqual(400); - expect(result.message).toEqual('Query error: 400 Bad Request'); + expect(result.status).toEqual("error"); + expect(result.message).toEqual('Query error: Bad Request'); }); }); }); diff --git a/src/datasource.ts b/src/datasource.ts index 0308e3c..d54c07d 100644 --- a/src/datasource.ts +++ b/src/datasource.ts @@ -1,5 +1,5 @@ import { DataSourceInstanceSettings, ScopedVars } from '@grafana/data'; -import { DataSourceWithBackend, getBackendSrv, getTemplateSrv, toDataQueryError } from '@grafana/runtime'; +import { DataSourceWithBackend, getBackendSrv, getTemplateSrv } from '@grafana/runtime'; import { TrinoDataSourceOptions, TrinoQuery } from './types'; import { TrinoDataVariableSupport } from './variable'; import { lastValueFrom, of } from 'rxjs'; @@ -40,7 +40,10 @@ export class DataSource extends DataSourceWithBackend { - return of(toDataQueryError(err)); + return of({ + status: 'error', + message: err.error ? err.error : (err.statusText ? ("Query error: " + err.statusText) : "Error connecting to Trino"), + }); }) ) );