From 9271e22ca11103ac1cf7bc2597f4527ba32e5270 Mon Sep 17 00:00:00 2001 From: Yuya Ebihara Date: Sat, 6 Jan 2024 08:58:58 +0900 Subject: [PATCH] Enforce ErrorProne MissingOverride --- .../trino/gateway/ha/clustermonitor/ActiveClusterMonitor.java | 2 ++ .../trino/gateway/ha/handler/QueryIdCachingProxyHandler.java | 1 + .../main/java/io/trino/gateway/ha/router/HaGatewayManager.java | 2 ++ .../main/java/io/trino/gateway/ha/security/LbOAuthManager.java | 3 +++ .../java/io/trino/gateway/proxyserver/ProxyServletImpl.java | 1 + .../main/java/io/trino/gateway/proxyserver/RequestFilter.java | 3 +++ .../proxyserver/wrapper/MultiReadHttpServletRequest.java | 1 + pom.xml | 1 + 8 files changed, 14 insertions(+) diff --git a/gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ActiveClusterMonitor.java b/gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ActiveClusterMonitor.java index 46d01b223..bc3a6842e 100644 --- a/gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ActiveClusterMonitor.java +++ b/gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ActiveClusterMonitor.java @@ -68,6 +68,7 @@ public ActiveClusterMonitor( /** * Run an app that queries all active trino clusters for stats. */ + @Override public void start() { singleTaskExecutor.submit( @@ -110,6 +111,7 @@ public void start() /** * Shut down the app. */ + @Override public void stop() { this.monitorActive = false; diff --git a/gateway-ha/src/main/java/io/trino/gateway/ha/handler/QueryIdCachingProxyHandler.java b/gateway-ha/src/main/java/io/trino/gateway/ha/handler/QueryIdCachingProxyHandler.java index 9a6dc4419..9b5782496 100644 --- a/gateway-ha/src/main/java/io/trino/gateway/ha/handler/QueryIdCachingProxyHandler.java +++ b/gateway-ha/src/main/java/io/trino/gateway/ha/handler/QueryIdCachingProxyHandler.java @@ -314,6 +314,7 @@ public String rewriteTarget(HttpServletRequest request) return targetLocation; } + @Override protected void postConnectionHook( HttpServletRequest request, HttpServletResponse response, diff --git a/gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java b/gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java index e7a5c23f5..3047d9f4d 100644 --- a/gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java +++ b/gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java @@ -130,6 +130,7 @@ public void activateBackend(String backendName) } } + @Override public ProxyBackendConfiguration addBackend(ProxyBackendConfiguration backend) { try { @@ -142,6 +143,7 @@ public ProxyBackendConfiguration addBackend(ProxyBackendConfiguration backend) return backend; } + @Override public ProxyBackendConfiguration updateBackend(ProxyBackendConfiguration backend) { try { diff --git a/gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java b/gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java index 2a9a44bbb..2eabffcd2 100644 --- a/gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java +++ b/gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java @@ -211,6 +211,7 @@ public String getExpiresIn() return this.expiresIn; } + @Override public boolean equals(final Object o) { if (o == this) { @@ -249,6 +250,7 @@ public boolean equals(final Object o) return Objects.equals(expiresIn, otherExpiresIn); } + @Override public int hashCode() { final int prime = 59; @@ -268,6 +270,7 @@ public int hashCode() return result; } + @Override public String toString() { return "LbOAuthManager.OidcTokens(accessToken=" + this.getAccessToken() + diff --git a/gateway-ha/src/main/java/io/trino/gateway/proxyserver/ProxyServletImpl.java b/gateway-ha/src/main/java/io/trino/gateway/proxyserver/ProxyServletImpl.java index 374dc5f38..50bf41ff0 100644 --- a/gateway-ha/src/main/java/io/trino/gateway/proxyserver/ProxyServletImpl.java +++ b/gateway-ha/src/main/java/io/trino/gateway/proxyserver/ProxyServletImpl.java @@ -102,6 +102,7 @@ protected String rewriteTarget(HttpServletRequest request) /** * Customize the response returned from remote server. */ + @Override protected void onResponseContent( HttpServletRequest request, HttpServletResponse response, diff --git a/gateway-ha/src/main/java/io/trino/gateway/proxyserver/RequestFilter.java b/gateway-ha/src/main/java/io/trino/gateway/proxyserver/RequestFilter.java index f434cec29..9006cc740 100644 --- a/gateway-ha/src/main/java/io/trino/gateway/proxyserver/RequestFilter.java +++ b/gateway-ha/src/main/java/io/trino/gateway/proxyserver/RequestFilter.java @@ -31,17 +31,20 @@ public class RequestFilter { private FilterConfig filterConfig; + @Override public void init(FilterConfig filterConfig) throws ServletException { this.filterConfig = filterConfig; } + @Override public void destroy() { this.filterConfig = null; } + @Override public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException { diff --git a/gateway-ha/src/main/java/io/trino/gateway/proxyserver/wrapper/MultiReadHttpServletRequest.java b/gateway-ha/src/main/java/io/trino/gateway/proxyserver/wrapper/MultiReadHttpServletRequest.java index abf2b0360..8ea1772c3 100644 --- a/gateway-ha/src/main/java/io/trino/gateway/proxyserver/wrapper/MultiReadHttpServletRequest.java +++ b/gateway-ha/src/main/java/io/trino/gateway/proxyserver/wrapper/MultiReadHttpServletRequest.java @@ -122,6 +122,7 @@ public boolean isReady() @Override public void setReadListener(ReadListener readListener) {} + @Override public int read() throws IOException { diff --git a/pom.xml b/pom.xml index 07f2fd204..f82c3b665 100644 --- a/pom.xml +++ b/pom.xml @@ -115,6 +115,7 @@ -XDcompilePolicy=simple -Xplugin:ErrorProne + -Xep:MissingOverride:ERROR \ -Xep:DoubleBraceInitialization:OFF