Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorrtllm_backend/scripts /launch_triton_server.py parse_arguments () typo correction #627

Closed
ankur1-samsung opened this issue Oct 22, 2024 · 2 comments

Comments

@ankur1-samsung
Copy link

ankur1-samsung commented Oct 22, 2024

current code :
parser.add_argument( '--log-file', type=str, help='path to triton log gile', default='triton_log.txt', )

to be ->
parser.add_argument( '--log-file', type=str, help='path to triton log file', default='triton_log.txt', )

I would like to create a PR for this change.

@ankur1-samsung
Copy link
Author

#628

@Tabrizian
Copy link
Member

Tabrizian commented Oct 24, 2024

Thanks for bringing this up. We've incorporated this change. It should be updated in the next weekly drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants