Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixir_eulergravity_jeans_instability.jl crashes with given CFL #2088

Closed
DanielDoehring opened this issue Sep 25, 2024 · 2 comments · Fixed by #2089
Closed

elixir_eulergravity_jeans_instability.jl crashes with given CFL #2088

DanielDoehring opened this issue Sep 25, 2024 · 2 comments · Fixed by #2089
Labels
bug Something isn't working

Comments

@DanielDoehring
Copy link
Contributor

The example examples/paper_self_gravitating_gas_dynamics/elixir_eulergravity_jeans_instability.jl crashes with the supplied values for CFL Euler and CFL Gravity. With the values from the paper it runs.

@DanielDoehring DanielDoehring added the bug Something isn't working label Sep 25, 2024
@ranocha
Copy link
Member

ranocha commented Sep 26, 2024

That's bad. I wonder why it wasn't seen in CI. Looks like the change comes from https://github.com/trixi-framework/Trixi.jl/pull/326/files#diff-1c1b525549c1f59356be3f3049d0c2a66582d28e6b4959b17bf5830afc7452dd. I wonder whether it ran back then...
Could you please fix the example by adapting the CFL number? It may also be something different from the values we used in the paper (since Trixi.jl was quite different back then).

@andrewwinters5000
Copy link
Member

That is very strange. I wonder if it was related to switching from our hand rolled CarpenterKennedy 5-stage, order 4 implementation to the ODE library...In any case this was a good catch and fix in #2089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants