Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI pipeline needs optimization #2197

Closed
huiyuxie opened this issue Dec 10, 2024 · 5 comments · Fixed by #2254
Closed

CI pipeline needs optimization #2197

huiyuxie opened this issue Dec 10, 2024 · 5 comments · Fixed by #2254
Labels
refactoring Refactoring code without functional changes testing

Comments

@huiyuxie
Copy link
Member

I do think it is an issue that it takes too long to run a full round of tests in the CI pipeline. At least from the contributor/developer's point of view, it slows down the feedback loop when debugging.

One straightforward problem is that the test infrastructure is mixed with examples, which introduces some unnecessary output that slow down the tests. So probably tests should be separate from examples.

@ranocha @sloede

@huiyuxie huiyuxie added the refactoring Refactoring code without functional changes label Dec 10, 2024
@sloede
Copy link
Member

sloede commented Dec 10, 2024

We concur, the long cycle time for running the full set of tests is annoying. Unfortunately, however, we currently have no better way of testing all features that is sustainable in terms of maintenance. Furthermore, we consider the examples to be part of the Trixi.jl implementation, thus they need to be tested as well.

If you have a concrete suggestion on how to improve testing times without losing coverage and without increasing the test complexity even further, we'd be happy to discuss it!

@huiyuxie
Copy link
Member Author

If you have a concrete suggestion on how to improve testing times without losing coverage and without increasing the test complexity even further, we'd be happy to discuss it!

I can give it a try but it won’t start soon due to my schedule.

@ranocha
Copy link
Member

ranocha commented Jan 21, 2025

We should check the results we get without splitting into tests with/without coverage. I would expect better behavior in Julia 1.10 than in the old versions that led to the splitting we have right now.

@JoshuaLampert
Copy link
Member

This can probably be closed after #2254 is merged.

@huiyuxie
Copy link
Member Author

Thanks for referring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring code without functional changes testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants