Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification creation race condition #34

Open
roger-ce opened this issue Mar 16, 2022 · 1 comment
Open

Notification creation race condition #34

roger-ce opened this issue Mar 16, 2022 · 1 comment

Comments

@roger-ce
Copy link

I seem to be running into a race condition where the 'scan' Lambda resource is just a second or two too slow being created, so when TF tries to add the Notification(s), the Lambda ARN doesn't exist yet. This leads me to have to run the apply twice, at which point it finishes successfully, but is particularly annoying when running in a CI/CD pipeline.
Could a simple 'depends_on = [aws_lambda_function.main_scan]' be added to the bucket notification resource definition please? I can raise a PR if that's easier.
Thanks!

@rpdelaney
Copy link
Contributor

@roger-ce Sorry for the slow comms. Please send a PR and we'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants