Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The esbuild dependency has all platforms available in the macOS distributable #138

Open
dceddia opened this issue Oct 2, 2023 · 1 comment
Labels
Bug Something isn't working Chore

Comments

@dceddia
Copy link

dceddia commented Oct 2, 2023

First off I just wanted to say this is an amazing project. Excellent work! It's a ton of fun to play around with.

I'm always curious about what's inside native apps so I almost reflexively clicked into Show Package Contents on Triplex.app. It's pretty common for Frameworks to be big because of Electron, but Resources was big too, and I noticed all of it is in node_modules (seems reasonable), and then most of that is in @esbuild – 175mb worth!

I'm not sure what step of the Electron build process this would go in, but it seems like this folder could be pruned (almost?) entirely and save a bunch of space in the download. It seems it shouldn't need those binaries during runtime, and there might be other folders that could be pruned too (esbuild, vite, and rollup probably?).

CleanShot 2023-10-02 at 11 30 16@2x

@itsdouges itsdouges added the Chore label Oct 2, 2023
@itsdouges
Copy link
Collaborator

Thank you! Yeah we definitely don't need to be including all the platform esbuild packages, hey! Good catch. Will update this issue to be both resolving this + adding ASAR archiving.

@itsdouges itsdouges changed the title Download size The esbuild dependency has all platforms available in the macOS distributable Oct 2, 2023
@itsdouges itsdouges added the Bug Something isn't working label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Chore
Projects
None yet
Development

No branches or pull requests

2 participants