-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read property 'Path' of undefined #97
Comments
got it, since I'm working with Polymer I will adapt the code to ES modules and if it works correctly I'll send you a PR so maybe you can create a 3.0 preview branch too 😄 |
Looking forward to the PR, Thanks!
…On Wed, 30 Aug 2017 at 22:30, Salvatore Laisa ***@***.***> wrote:
got it, since I'm working with Polymer 3.0-preview branch there is no
global Polymer object and this line
https://github.com/tur-nr/polymer-redux/blob/master/src/index.js#L62
breaks.
I will adapt the code to ES modules and if it works correctly I'll send
you a PR so maybe you can create a 3.0 preview branch too 😄
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#97 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAx37k6e7gpIl68DpcVfyt-ZvfK9Jfbuks5sdVX5gaJpZM4PHNL0>
.
|
@tur-nr fixed! I'm doing the PR but I see you only have master branch, PR there anyway or you want to create a preview branch where I can PR to? |
for me, changing the line Polymer.Path.get(state, statePath); to window.Polymer.Path.get(state, statePath); make it work |
I'm upgrading
1.x
elements withpolymer-redux 0.4.2
to2.x/3.x
element syntax andpolymer-redux 1.0.2
, following the docs it's all going fine, but thestatePath
attribute to properties throws the error in the title. During the refactor the store has remained unchanged and updates on event dispatching.Someone has any ideas?
The text was updated successfully, but these errors were encountered: