Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can’t set ‘Low’ and ‘High’ string for HEATSTRIP Convector Heater #380

Closed
ThorkelAU opened this issue Feb 4, 2024 · 2 comments
Closed
Labels
bug Something isn't working no-issue-activity

Comments

@ThorkelAU
Copy link

Describe the bug
The Heatstrip convector heater uses ‘level_1’ and ‘level_2’ for the Low and High setting on dpRotationSpeed. ConvectorAccessory.js has an Alphanumeric test on line 32 that doesn’t include _ - so the accessory doesn’t get added.

Expected behavior

Changing the test for CmdLow (and similarly for CmdHigh) to the following allows the ‘level_1’ and ‘level_2’ string to work, and ensures the heater gets added when the plugin initialises.

if (/^[a-z0-9_]+$/i.test(this.device.context.cmdLow)) this.cmdLow = ('' + this.device.context.cmdLow).trim();

@ThorkelAU ThorkelAU added the bug Something isn't working label Feb 4, 2024
Copy link

github-actions bot commented Feb 4, 2024

Thank you for your feedback, we will solve this issue soon

Copy link

github-actions bot commented Apr 5, 2024

Stale issue. we will close the issue soon. If this issue has not been resolved, please update the issue and contact us in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Development

No branches or pull requests

1 participant