-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visualizations #18
Comments
I have been playing around with this and came over to file an issue to ask if this kind of addition would be welcome -- I have some considerable clean-up to do; the code is super messy and styling has to be considered (colors are just hardcoded from an example instead of auto-generated for each new data point). But assuming clean-up, it seems like this would be a fine PR to make. Are there more specific things you had in mind re: visualizations/reporting, Tim? |
Ashley! This is so great! This is just the kind of thing I had in mind. A great addition! I'll follow up the details in PR #22, but thank you so much! |
OK! Yeah it still needs a bit of cleanup, I think, for better positioning ... but glad you like it and I'll keep moving forward! I wonder what other kinds of visualizations are useful? |
Yay! A bit of spitballing:
I just merged your branch here and made the semantic changes I mentioned in the PR. Feel free to hack away on the visualizations (I'm assuming time/interest here - you've already made such great contributions here, please feel free to step away at any time!) and maybe I'll focus on the backend changes to support types of files other than original. |
Another idea that would also take some backend work: it could be interesting to try to visualize the relationships between the original files and their preservation derivatives - comparing formats before and after, for instance |
Yes! Yeah I'm still interested, even if my freetime is a bit low for this work so PRs won't be as fervent as I'd like them to be. But I gotta keep my skills up! |
I totally get that! Sounds good :) |
Hi Ashley! I did a bit more layout work on this and think it's ready to go live as-is if you're keen! Of course you're always welcome to open new PRs too :) |
omg thanks!! My free time has stayed low since October although I do think about this and wanting to contribute. Don't let my lack of time block you in any way. |
Thank you! I appreciate that you spent some of your rare free time on this, and the door will always be open if you wanna do any more! I'm going to leave this issue open as a reminder to swing back and generalize the visualization beyond formats at some point... |
Of course! It really wasn't much work at all -- I like to think the biggest part was motivating you to do even MORE work after me to tidy up my sloppy quickly-drafted mess. 😂 |
e.g. pie charts using D3.js
The text was updated successfully, but these errors were encountered: