Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated getServerSideProps function and clunky imports / config option retrieval in client #417

Open
simeoncarstens opened this issue Feb 1, 2023 · 0 comments
Open

Duplicated getServerSideProps function and clunky imports / config option retrieval in client #417

simeoncarstens opened this issue Feb 1, 2023 · 0 comments
Labels
client Related to the front-end javascript Pull requests that update Javascript code

Comments

@simeoncarstens
Copy link
Member

In app/client/pages/{job,dash,results}.js, there is duplicated code, namely the getServerSideProps function. Furthermore, in #415, I struggled to find a consistent way to retrieve the require_auth option from next.config.js and to import / require firebaseClient and firebaseAdmin only when they are needed.
All of these work, but should be refactored.
@simeoncarstens simeoncarstens added client Related to the front-end javascript Pull requests that update Javascript code labels Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client Related to the front-end javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simeoncarstens