Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.1.1 broke the Status callbacks #156

Open
marocano1 opened this issue Jan 8, 2025 · 1 comment
Open

8.1.1 broke the Status callbacks #156

marocano1 opened this issue Jan 8, 2025 · 1 comment

Comments

@marocano1
Copy link

The changes made in 8.1.1, specifically turning the nullable feature on, has broken the Status callbacks. Every property that does not have the nullable operator, (i.e. '?'), is now required.

image

Due to that, our status callback endpoint has been returning a 400 because the "Body" property on the SmsRequest class, which is the base class for the SmsStatusCallbackRequest class, is now required.

image

image

This is a breaking change that was introduced with 8.1.1. Can we please get a fix in for it as soon as possible?

@Swimburger
Copy link
Contributor

You can make a copy of the class locally and fix it as a temporary fix.
Feel free to make a PR here too.

For now, making that field nullable would be the best fix.
However, longer term, we should consider not inheriting from VoiceRequest and SmsRequest for the callback classes.
Unfortunately, Twilio doesn't document their callbacks very well (callbacks issue OpenAPI), so the code in this repo is best effort based on their documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants