You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We get a lot of errors that this._conversationsPromise is undefined when trying to call getSubscribedConversations on a channel. Let's take a look at getSubscribedConversations:
Let's look how _ensureReady is defined in client.js of @twilio/conversations
this._ensureReady = new Promise((resolve, reject) => {
this._resolveEnsureReady = resolve;
this._rejectEnsureReady = reject;
}).catch(() => void 0); // @todo How to process unhandled rejection here?
Well, it seems that there is a bug here and await this._ensureReady will never throw because you swallowed the error. Since you swallowed the error we get to the next line return this._conversationsPromise.... But we can't be sure that _conversationsPromise was set.
You should remove that catch on _ensureReady in Client constructor. At least users or your library would get the original error.
The text was updated successfully, but these errors were encountered:
We get a lot of errors that
this._conversationsPromise
is undefined when trying to callgetSubscribedConversations
on a channel. Let's take a look atgetSubscribedConversations
:Let's look how
_ensureReady
is defined inclient.js
of@twilio/conversations
Well, it seems that there is a bug here and
await this._ensureReady
will never throw because you swallowed the error. Since you swallowed the error we get to the next linereturn this._conversationsPromise...
. But we can't be sure that_conversationsPromise
was set.You should remove that
catch
on_ensureReady
in Client constructor. At least users or your library would get the original error.The text was updated successfully, but these errors were encountered: