Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwilioHttpClient: max_retries is ignored #829

Open
calebsyring opened this issue Dec 30, 2024 · 1 comment · May be fixed by #834
Open

TwilioHttpClient: max_retries is ignored #829

calebsyring opened this issue Dec 30, 2024 · 1 comment · May be fixed by #834

Comments

@calebsyring
Copy link

Issue Summary

The second block/adapter below will always override the first block/adapter, so max_retries is always ignored.

if self.session and max_retries is not None:
self.session.mount("https://", HTTPAdapter(max_retries=max_retries))
if self.session is not None:
self.session.mount(
"https://", HTTPAdapter(pool_maxsize=min(32, os.cpu_count() + 4))
)

Steps to Reproduce

N/A

Code Snippet

N/A

Exception/Log

N/A

Technical details:

  • twilio-python version: 9.3.2
  • python version: 3.12.4
@manisha1997 manisha1997 linked a pull request Jan 17, 2025 that will close this issue
8 tasks
@manisha1997
Copy link
Contributor

working on the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants