Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve URL spec suite #97

Open
dentarg opened this issue Sep 15, 2016 · 0 comments
Open

Improve URL spec suite #97

dentarg opened this issue Sep 15, 2016 · 0 comments

Comments

@dentarg
Copy link
Collaborator

dentarg commented Sep 15, 2016

I think that we need to create a new structure for url_spec.rb. It worked well with one-dimensional arrays when we just asserted invalid/valid, but since then we added many corner cases, and it would be good to be able to assert each and every part on many of the URLs we have in the spec file. We want to do this for the non-normalized version and the normalized version.

One example of a structured way of testing many inputs is https://github.com/weppos/publicsuffix-ruby/blob/v2.0.2/test/tests.txt, but it's only one output, so I think we have to come up with something slightly more advanced.

I have also started to add comments about some of the URLs in the spec, might be something we can even incorporate in the rspec output, if we find a good structure.

A bit related to the table idea for examples, #96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant