Import in service class is broken for nested request and response messages

[antonkomarev]

Preflight Checklist

• I have searched the issue tracker for an issue that matches the one I want to file, without success.
• I am not looking for support or already pursued the available support channels without success.

Version

0.12.0

PHP version

8.2

Go version

No response

Expected Behavior

interface EmployeeService
{
    public function ListEmployee(
        array $ctx,
        \Org\Example\ListEmployee\Request $req
    ): \Org\Example\ListEmployee\Response;
}

Actual Behavior

Messages are generated correctly by protoc, but service interface has broken imports if Request and Response messages are nested.

interface EmployeeService
{
    public function ListEmployee(
        array $ctx,
        \Org\Example\Request $req
    ): \Org\Example\Response;
}

Steps To Reproduce

syntax = "proto3";

package org.example;

service EmployeeService {
  rpc ListEmployee(ListEmployee.Request) returns (ListEmployee.Response);
}

message ListEmployee {
  message Request {
    string organization_id = 1;
  }

  message Response {
    oneof response {
      Result result = 1;
      string access_denied = 2;
    }

    message Result {
      repeated Employee employees = 1;
    }

    message Employee {
      string id = 1;
      string name = 2;
    }
  }
}

Generate code with:

./bin/proto/${ARCH}/protoc \
    --plugin=protoc-gen-twirp_php=./bin/proto/${ARCH}/protoc-gen-twirp_php \
    -I=./proto \
    -I=./proto/include \
    --twirp_php_out=./generated \
    --php_out=./generated \
    $(find ./proto -name "*.proto" -not -path "./proto/include/*")

Additional Information

No response

[sagikazarmark]

Thanks for reporting!

I rarely use nested messages TBH.

Are you interested in contributing a failing test case and a patch?

[antonkomarev]

@sagikazarmark I just found a spec with nested request & response and it's working well in TypeScript Twirp generator, but not working for PHP.

• PR as you requested: Fix nested Request & Response messages #203