Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maybe) put hypothesis back #588

Open
glyph opened this issue May 3, 2023 · 4 comments
Open

(maybe) put hypothesis back #588

glyph opened this issue May 3, 2023 · 4 comments

Comments

@glyph
Copy link
Member

glyph commented May 3, 2023

#586 removed hypothesis, but left the door open for re-integrating it if we can address a couple of issues:

@exarkun
Copy link
Member

exarkun commented May 3, 2023

fix the bug in Hyperlink's strategies that generates bogus URLs python-hyper/hyperlink#153

I fixed this almost a year ago with absolutely no response from the maintainers. Any ideas how to actually get any changes in to Hyperlink?

@Zac-HD
Copy link

Zac-HD commented May 4, 2023

👋 I can't do much about the hyperlink issue, but happy to help you find a hypothesis workflow you like. It sounds like this suggestion from @nelhage might work well:

  • use Hypothesis' settings to run only the explicit phase, i.e. inputs in @example(...) decorators. This is fully deterministic, and basically equivalent to @pytest.mark.parametrize().
  • have a separate cronjob in CI which runs just the Hypothesis tests on trunk with all phases, to find new failures which you can add to those explicit decorators.

Alternatively, using e.g. max_examples=20, derandomize=True in your CI settings might be sufficient to meet your goals.

@glyph
Copy link
Member Author

glyph commented May 4, 2023

fix the bug in Hyperlink's strategies that generates bogus URLs python-hyper/hyperlink#153

I fixed this almost a year ago with absolutely no response from the maintainers. Any ideas how to actually get any changes in to Hyperlink?

Hmm. Apparently I'm a maintainer so maybe I can do something about that. Are you referring to this? python-hyper/hyperlink#178 Was it ever passing CI?

@exarkun
Copy link
Member

exarkun commented May 5, 2023

fix the bug in Hyperlink's strategies that generates bogus URLs python-hyper/hyperlink#153

I fixed this almost a year ago with absolutely no response from the maintainers. Any ideas how to actually get any changes in to Hyperlink?

Hmm. Apparently I'm a maintainer so maybe I can do something about that. Are you referring to this? python-hyper/hyperlink#178 Was it ever passing CI?

That's the one, yes. I don't remember any of the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants