From 94f13a29c8f051f8956b583ef31b86578f5d0daf Mon Sep 17 00:00:00 2001 From: duidae Date: Wed, 4 Jan 2023 15:57:29 +0800 Subject: [PATCH] Revert "Revert "Revert "Jason/refinement new arch""" This reverts commit 991bb425789940a68ec3f427cb293b7683b07a95. --- .../src/components/article-page.js | 8 ++--- .../src/components/aside/metadata.js | 3 +- .../src/components/body/index.js | 3 +- .../src/components/leading/normal.js | 14 ++------ .../src/bookmark-list/bookmarks.js | 12 +++---- .../src/listing-page/components/list.js | 35 +++++++++++++------ .../listing-page/components/topics/index.js | 20 ++++------- .../components/{ => topics}/page-content.js | 6 ++-- .../listing-page/components/topics/section.js | 28 ++++++++++----- 9 files changed, 64 insertions(+), 65 deletions(-) rename packages/react-components/src/listing-page/components/{ => topics}/page-content.js (84%) diff --git a/packages/react-article-components/src/components/article-page.js b/packages/react-article-components/src/components/article-page.js index 3ebfeebfd..5532baa73 100644 --- a/packages/react-article-components/src/components/article-page.js +++ b/packages/react-article-components/src/components/article-page.js @@ -30,7 +30,7 @@ const _ = { const shiftLeftCss = css` position: relative; - /* 20px is border-(right|left) width of article page */ + /* 20px is border-(right|left) width of articlePage */ width: calc(100% + 20px); left: -10px; ` @@ -111,8 +111,8 @@ const DesktopAsideBlock = styled.div` const MetadataAndToolsBlock = styled.div` ${mq.mobileOnly` - padding-top: 33px; - padding-bottom: 33px; + padding-top: 40px; + padding-bottom: 60px; `} ${mq.tabletOnly` @@ -192,7 +192,7 @@ const BackgroundBlock = styled(BorderBox)` } } - /* border-(right|left) of article page */ + /* boreder-(right|left) of articlePage */ padding-left: 10px; padding-right: 10px; ` diff --git a/packages/react-article-components/src/components/aside/metadata.js b/packages/react-article-components/src/components/aside/metadata.js index 8eed8a185..f7acc360c 100644 --- a/packages/react-article-components/src/components/aside/metadata.js +++ b/packages/react-article-components/src/components/aside/metadata.js @@ -201,8 +201,7 @@ const MetadataContainer = styled.div` letter-spacing: 0.4px; ${mq.mobileOnly` - padding-left: 24px; - padding-right: 24px; + width: calc(300/355*100%); margin: 0 auto; `} diff --git a/packages/react-article-components/src/components/body/index.js b/packages/react-article-components/src/components/body/index.js index b072c5d1c..287a057b0 100644 --- a/packages/react-article-components/src/components/body/index.js +++ b/packages/react-article-components/src/components/body/index.js @@ -84,8 +84,7 @@ const largeWidthCSS = css` const normalWidthCSS = css` ${mq.mobileOnly` - padding-left: 34px; - padding-right: 34px; + width: calc(300/375*100%); `} ${mq.tabletOnly` width: 453px; diff --git a/packages/react-article-components/src/components/leading/normal.js b/packages/react-article-components/src/components/leading/normal.js index 23f21c1da..0729d12a7 100644 --- a/packages/react-article-components/src/components/leading/normal.js +++ b/packages/react-article-components/src/components/leading/normal.js @@ -28,8 +28,7 @@ const TextBlock = styled.div` margin: 0 auto; ${mq.mobileOnly` - padding-left: 24px; - padding-right: 24px; + width: calc(327/375*100%); `} ${mq.tabletOnly` @@ -50,7 +49,6 @@ const Title = styled.h1` ${mq.mobileOnly` font-size: 34px; - margin-bottom: 38px; `} ${mq.tabletAndAbove` @@ -111,16 +109,8 @@ const FigCaption = styled.figcaption` const BackgroundBlock = styled.div` ${props => getBackgroundBlockStyles(props.theme.name)} - ${mq.hdOnly` - padding-top: 100px; - `} - ${mq.desktopOnly` - padding-top: 48px; - `} + padding-top: 30px; ${mq.tabletOnly` - padding-top: 32px; - `} - ${mq.mobileOnly` padding-top: 30px; `} ` diff --git a/packages/react-components/src/bookmark-list/bookmarks.js b/packages/react-components/src/bookmark-list/bookmarks.js index fdde4f799..ce70578f2 100644 --- a/packages/react-components/src/bookmark-list/bookmarks.js +++ b/packages/react-components/src/bookmark-list/bookmarks.js @@ -37,10 +37,10 @@ const PageContainer = styled.div` const Column = styled.div` margin: 0 auto; width: 97%; - max-width: 922px; + max-width: 834px; ${mq.tabletOnly` width: 100%; - max-width: 698px; + max-width: 707px; `} ${mq.mobileOnly` width: 100%; @@ -49,12 +49,8 @@ const Column = styled.div` const StatusBar = styled.div` ${mq.mobileOnly` - padding-left: 24px; - padding-right: 24px; - padding-bottom: 24px; - `} - ${mq.tabletOnly` - padding-bottom: 32px; + padding-left: 1em; + padding-right: 1em; `} padding-bottom: 64px; width: stretch; diff --git a/packages/react-components/src/listing-page/components/list.js b/packages/react-components/src/listing-page/components/list.js index 218b7dcec..65f4f12e4 100644 --- a/packages/react-components/src/listing-page/components/list.js +++ b/packages/react-components/src/listing-page/components/list.js @@ -5,12 +5,12 @@ import styled from 'styled-components' import entityPaths from '@twreporter/core/lib/constants/entity-path' import mq from '@twreporter/core/lib/utils/media-query' import { date2yyyymmdd } from '@twreporter/core/lib/utils/date' +import { fontWeight } from '@twreporter/core/lib/constants/font' // constants import mockup from '../constants/mockup-spec' +import color from '../constants/color' // components import ListItem from './list-item' -import PageContent from './page-content' -import { TitleBar } from '../../title-bar' import FetchingWrapper from '../../is-fetching-wrapper' // lodash import forEach from 'lodash/forEach' @@ -23,9 +23,26 @@ const _ = { map, } +const Container = styled.div` + margin: 45px auto 0 auto; +` + +const Header = styled.div` + font-size: 36px; + font-weight: ${fontWeight.bold}; + color: ${color.darkDarkGray}; + margin: 0 auto 45px auto; + text-align: center; + + ${mq.mobileOnly` + width: ${(mockup.mobile.cardWidth / mockup.mobile.maxWidth) * 100}%; + text-align: left; + `} +` + const FlexItems = styled.div` width: ${mockup.hd.maxWidth}px; - margin: 64px auto 0; + margin: 0 auto; display: flex; justify-content: flex-start; align-items: flex-start; @@ -41,12 +58,10 @@ const FlexItems = styled.div` ${mq.tabletOnly` width: ${mockup.tablet.maxWidth}px; - margin-top: 32px; `} ${mq.mobileOnly` width: 100%; - margin-top: 24px; > div:nth-child(odd) { margin-right: 0; } @@ -106,17 +121,15 @@ class List extends PureComponent { /> ) }) - const headerTitle = catName || tagName - const headerJSX = headerTitle ? ( - - ) : null + const headerTitle = catName || (tagName ? `#${tagName}` : '') + const headerJSX = headerTitle ?
{headerTitle}
: null return ( - + {headerJSX} {listJSX} - + ) } } diff --git a/packages/react-components/src/listing-page/components/topics/index.js b/packages/react-components/src/listing-page/components/topics/index.js index c9caab16f..647aaf5d8 100644 --- a/packages/react-components/src/listing-page/components/topics/index.js +++ b/packages/react-components/src/listing-page/components/topics/index.js @@ -6,14 +6,13 @@ import FetchingWrapper from '../../../is-fetching-wrapper' import PostsContainer from './posts' import PostItem from './post-item' import TopicItem from './topic-item' -import PageContent from '../page-content' -import { TopSectionContent, ListSectionContent } from './section' +import PageContent from './page-content' +import { TopSectionContent, ListSectionContent, SectionTitle } from './section' // constants import { TEXT } from '../../constants/topics' import color from '../../constants/color' // @twreporter import { fontWeight } from '@twreporter/core/lib/constants/font' -import { TitleBar } from '@twreporter/react-components/lib/title-bar' // lodash import get from 'lodash/get' import map from 'lodash/map' @@ -31,8 +30,6 @@ const NoData = styled.div` text-align: center; ` -const topicTitleText = '深度專題' - class Topics extends Component { _buildRelatedPosts(posts) { const _buildPostJSX = post => { @@ -100,11 +97,9 @@ class Topics extends Component { topTopicName = _.get(topics, [0, 'topic_name'], '') topicUrl = _.get(topics, [0, 'linkTo'], '') topSectionJSX = [ - , + + {TEXT.SECTION_TITLE_FEATURED} + , {topSectionJSX} {isFetching && isFirstPage ? null : ( - + {TEXT.SECTION_TITLE_OTHERS} )}