Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unhappy paths in Connection tests #180

Open
alexjpwalker opened this issue Feb 23, 2021 · 0 comments
Open

Check unhappy paths in Connection tests #180

alexjpwalker opened this issue Feb 23, 2021 · 0 comments

Comments

@alexjpwalker
Copy link
Member

alexjpwalker commented Feb 23, 2021

Problem to Solve

We have recently exposed a number of segfault and stalling issues caused by simple user errors: closing the transaction before a query finishes running, deleting the database and then trying to close a session... and so on.

While these are most certainly user errors, they should be handled gracefully, like any other user error. A segfault or stall is not an acceptable response in these scenarios.

Proposed Solution

We should add unhappy path tests to our Connection tests (Database, Session and Transaction). Basically just think of any scenario that could cause trouble because the user did a DB/session/tx operation they weren't meant to and write a test for it. (By tx operations, we do not mean syntactically/semantically invalid queries, but rather opening or closing a transaction at an illegal time)

@alexjpwalker alexjpwalker changed the title Test unhappy paths Check unhappy paths in Connection tests Feb 23, 2021
@sync-by-unito sync-by-unito bot closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants