Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Associating Log Group Name with Trace in Natchez and AWS X-Ray Daemon #1018

Open
ChristyGKrishnan opened this issue May 24, 2024 · 0 comments

Comments

@ChristyGKrishnan
Copy link

We are using Natchez for generating traces for AWS X-Ray. X-Ray allows logs to be attached to the traces being generated, provided the CloudWatch log group name is included in the traces sent to X-Ray through the daemon. However, Natchez does not currently support passing this property along with traces, and neither does the AWS X-Ray Daemon.

In the screenshot below, the log section is empty even though the logs have the trace ID and entity ID present

Screenshot from 2024-05-24 14-51-42
In the image above image log section is empty even though the logs has trace id and entityId present in the logs.

If the trace includes the following details:
"aws": {
"cloudwatch_logs": [
{
"log_group": ""
}
]
}
then logs will appear as shown below:
image

Proposed Solution:
Introduce a mechanism in Natchez to include the CloudWatch log group name in the trace annotations. Specifically, if a field named aws_group_name is present in the annotations, it should be added as the AWS CloudWatch log group in the trace.
have submitted a PR for the same.
Steps to Reproduce

  1. Use Natchez to send X-Ray traces and use the X-Ray Daemon as the collector.
  2. Add trace and span details in the logs.
    3.Verify if the CloudWatch logs are included with the trace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant