Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logic of state change from App component #65

Open
rmcreyes opened this issue Nov 17, 2019 · 0 comments
Open

Remove logic of state change from App component #65

rmcreyes opened this issue Nov 17, 2019 · 0 comments
Assignees
Labels
dev type type type refactor Places we can tidy up
Milestone

Comments

@rmcreyes
Copy link
Collaborator

Describe the part of the code base that needs to be cleaned up
We currently have the logic for changing states in the App component. This makes it hard to test if state changes are being handled correctly.

Provide suggestions on how we can clean this up
Define a function somewhere else that contains all the logic for changing state, and import it into the App component. Write unit tests to make sure the function runs as expected.

@rmcreyes rmcreyes added refactor Places we can tidy up dev type type type labels Nov 17, 2019
@chuck-sys chuck-sys self-assigned this Feb 1, 2020
@chuck-sys chuck-sys added this to the Term 2 milestone Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev type type type refactor Places we can tidy up
Projects
None yet
Development

No branches or pull requests

2 participants