You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the part of the code base that needs to be cleaned up
The GamePlayMode property is an enum that for most events, is set to the value Comics. The only cases where this is not the case is in the LandingEvent, where this value is set to AcceptanceLetter, which generates a letter out of HTML elements, and in the PickFacultyEvent, where this value is set to Hide, which removes the canvas for the image displayed.
Provide suggestions on how we can clean this up
There is a ticket to suggest the LandingEvent may need to be handled differently in #85 because of the hasBottomBoxBorder property, so this may also need to be taken into consideration for that.
With the regard to the PickFacultyEvent, in most cases we should have an image to display for every other case. With that in mind, it may be that we can just change GamePlayConsole to hide the canvas for the image instead of displaying a filler image, or we can handle PickFacultyEvent separately as well. In case we want to do this quicker, we could just do the former to close this ticket, and create a follow up issue to actually have special handling for picking your faculty.
The text was updated successfully, but these errors were encountered:
Describe the part of the code base that needs to be cleaned up
The
GamePlayMode
property is an enum that for most events, is set to the valueComics
. The only cases where this is not the case is in theLandingEvent
, where this value is set toAcceptanceLetter
, which generates a letter out of HTML elements, and in thePickFacultyEvent
, where this value is set toHide
, which removes the canvas for the image displayed.Provide suggestions on how we can clean this up
There is a ticket to suggest the
LandingEvent
may need to be handled differently in #85 because of thehasBottomBoxBorder
property, so this may also need to be taken into consideration for that.With the regard to the
PickFacultyEvent
, in most cases we should have an image to display for every other case. With that in mind, it may be that we can just changeGamePlayConsole
to hide the canvas for the image instead of displaying a filler image, or we can handlePickFacultyEvent
separately as well. In case we want to do this quicker, we could just do the former to close this ticket, and create a follow up issue to actually have special handling for picking your faculty.The text was updated successfully, but these errors were encountered: