Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for GamePlayMode property #86

Open
rmcreyes opened this issue Jan 17, 2020 · 0 comments
Open

Remove need for GamePlayMode property #86

rmcreyes opened this issue Jan 17, 2020 · 0 comments
Labels
dev type type type refactor Places we can tidy up

Comments

@rmcreyes
Copy link
Collaborator

rmcreyes commented Jan 17, 2020

Describe the part of the code base that needs to be cleaned up
The GamePlayMode property is an enum that for most events, is set to the value Comics. The only cases where this is not the case is in the LandingEvent, where this value is set to AcceptanceLetter, which generates a letter out of HTML elements, and in the PickFacultyEvent, where this value is set to Hide, which removes the canvas for the image displayed.

Provide suggestions on how we can clean this up
There is a ticket to suggest the LandingEvent may need to be handled differently in #85 because of the hasBottomBoxBorder property, so this may also need to be taken into consideration for that.

With the regard to the PickFacultyEvent, in most cases we should have an image to display for every other case. With that in mind, it may be that we can just change GamePlayConsole to hide the canvas for the image instead of displaying a filler image, or we can handle PickFacultyEvent separately as well. In case we want to do this quicker, we could just do the former to close this ticket, and create a follow up issue to actually have special handling for picking your faculty.

@rmcreyes rmcreyes added refactor Places we can tidy up dev type type type labels Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev type type type refactor Places we can tidy up
Projects
None yet
Development

No branches or pull requests

1 participant