Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #54

Open
abhinav opened this issue Sep 13, 2023 · 0 comments
Open

Windows support #54

abhinav opened this issue Sep 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@abhinav
Copy link
Collaborator

abhinav commented Sep 13, 2023

We believe that cff works on Windows just fine,
but the tests currently have hard-coded Linu paths.

This is tracking fixing those and re-enabling Windows builds.
abhinav added a commit to abhinav/cff that referenced this issue Sep 13, 2023
@abhinav
Drop windows support; will re-add in uber-go#54
d333d04
@abhinav abhinav mentioned this issue Sep 13, 2023
Merged
@abhinav abhinav added the enhancement New feature or request label Sep 13, 2023
abhinav added a commit that referenced this issue Sep 14, 2023
@abhinav
ci: Fix broken main (#52)
d288967 
CI on main is currently broken for several reasons:

- The Makefile wasn't Windows friendly.
- Some of the documentation had broken links.
- Some of the documentation was poorly formatted.
- Windows support is broken.

All but the last issue has been fixed by this PR.
We're dropping Windows support for now.
Two follow-ups were created: #53, #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhinav