Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Node 10 Support #355

Open
lxe opened this issue May 2, 2018 · 5 comments
Open

Node 10 Support #355

lxe opened this issue May 2, 2018 · 5 comments

Comments

@lxe
Copy link

lxe commented May 2, 2018

tchannel-node fails to build on Node 10 Stable due to farmhash 1.1.0 dependency

@Raynos
Copy link
Contributor

Raynos commented May 3, 2018

open an issue on farmhash.

@Raynos
Copy link
Contributor

Raynos commented May 3, 2018

farmhash @ latest supports node10 but it probably does not support node0.10.32 ; we may need conditional dependencies based on node versions.

@Raynos
Copy link
Contributor

Raynos commented May 3, 2018

since tchannel is in maintenance mode ; it makes sense to have a branch with node10.0 support and published as a seperate version number; maybe 3.9.12-node10-support

@ajbogh
Copy link
Contributor

ajbogh commented Apr 3, 2019

#356 should fix this issue.

Edit: My mistake, #356 does not fix this.

@ajbogh
Copy link
Contributor

ajbogh commented Apr 5, 2019

Node 0.10.0 works as long as a couple of flags are defined with the right values. The error with farmhash stems from the Mac version, and a lack of the utility class for farmhash's header file.

Use flags with npm rebuild (replace rebuild with install if desired):

CXXFLAGS="-mmacosx-version-min=10.9" LDFLAGS="-mmacosx-version-min=10.9" npm rebuild

To be clear, this fixes Node 0.10.0, which is not the same as Node 10. Node 10's fix is in #356.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants