This repository has been archived by the owner on May 3, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Node 10 Support #355
Comments
open an issue on farmhash. |
farmhash @ latest supports node10 but it probably does not support node0.10.32 ; we may need conditional dependencies based on node versions. |
since tchannel is in maintenance mode ; it makes sense to have a branch with node10.0 support and published as a seperate version number; maybe |
Node 0.10.0 works as long as a couple of flags are defined with the right values. The error with farmhash stems from the Mac version, and a lack of the Use flags with npm rebuild (replace
To be clear, this fixes Node 0.10.0, which is not the same as Node 10. Node 10's fix is in #356. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
tchannel-node fails to build on Node 10 Stable due to farmhash 1.1.0 dependency
The text was updated successfully, but these errors were encountered: