Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Score screen styling rules don't accommodate large feedbacks. #31

Open
FrenjaminBanklin opened this issue Nov 29, 2018 · 0 comments
Open

Score screen styling rules don't accommodate large feedbacks. #31

FrenjaminBanklin opened this issue Nov 29, 2018 · 0 comments
Assignees
@FrenjaminBanklin

Comments

@FrenjaminBanklin
Copy link
Contributor

FrenjaminBanklin commented Nov 29, 2018 •
edited
Loading

Feedback text blocks that wind up being taller than 80 pixels end up overlapping whatever happens to be in their way.

In general, the styling rules for the default score screen are a mess - display:table and related rules are used to approximate a table in lieu of just using a table.
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia-Server-Client-Assets that referenced this issue Nov 29, 2018
@FrenjaminBanklin
ucfopen#31 Modify styling rules to expect a table where the scores go…
16d4aef 
… instead of an unordered list that's hacked together to act like a table.
@FrenjaminBanklin FrenjaminBanklin mentioned this issue Nov 29, 2018
Merged
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia-Server-Client-Assets that referenced this issue Nov 29, 2018
@FrenjaminBanklin
ucfopen#31 Ran prettier.
18d6411
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia-Server-Client-Assets that referenced this issue Dec 5, 2018
@FrenjaminBanklin
ucfopen#31 Long words will break so the rows don't flow outside their…
860b297 
… container horizontally. Borders simulating drop shadows replaced with actual drop shadows.
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia-Server-Client-Assets that referenced this issue Dec 6, 2018
@FrenjaminBanklin
ucfopen#31 Ran prettier.
c0999a4
@FrenjaminBanklin FrenjaminBanklin self-assigned this Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrenjaminBanklin FrenjaminBanklin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FrenjaminBanklin