Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to move to dotnetcore/standard? #6

Open
stumpyfr opened this issue Jan 24, 2017 · 5 comments
Open

Any plan to move to dotnetcore/standard? #6

stumpyfr opened this issue Jan 24, 2017 · 5 comments

Comments

@stumpyfr
Copy link

I am starting a new project in dotnet core, I would need a compatible version.
If nothing is planned/started on your side, I will probably start a fork (or total new version) to make it work.

Waiting any feedback before developing stuff for nothing ;).

@mallat
Copy link
Contributor

mallat commented Jan 24, 2017

Hi Niels.
So far, we did not think about the .NET core.
If you want to do that, we will be happy to assist.
We recommend the usage of branch DEV, which is already nearly finished and a lot better than the branch master.

@mallat mallat closed this as completed Jan 24, 2017
@stumpyfr
Copy link
Author

I made a first version here: https://github.com/stumpyfr/udger-dotnet/tree/core
working with dotnet core and compatible with the full framework (need to generate the nuget package, directly load a .netcore library from a project with the full framework doesnt work well yet).

I made a very simple unit test, need to add more but everything look fine for a first (and quick) version.

I used the dynamic type, probably not the most efficient way, I need to take time to make it propertly.

You can run the test from Visual Studio of directly with the cli: dotnet test test/Udger.Core.Tests/project.json

I will try to finish that properly in the next few days but already open to any feedbacks

@mallat
Copy link
Contributor

mallat commented Jan 25, 2017

Hi.
Could you move it somewhere here https://github.com/udger ? For example udger-dotnetcore.

@mallat mallat reopened this Jan 25, 2017
@stumpyfr
Copy link
Author

Off course, soon as it's properly finish.
the idea would be to replace the current dotnet version, its the same code, I just made few modifications to make it compatible with .net standard1.6

@mallat
Copy link
Contributor

mallat commented Jan 25, 2017

OK.
I draw attention to an error in the recognition of device.
For example: Mozilla/5.0 (Linux; U; Android 4.0.4; sk-sk; Luna TAB474 Build/LunaTAB474) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Safari/534.30

The error is not in the .NET library, the error is in incompatible datafile. We are working on modifications off the data and it will be fixed soon. That is why the branch DEV is not reflected into branch MASTER.

@stumpyfr stumpyfr mentioned this issue Feb 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants