Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Linting #15

Open
awhigham9 opened this issue Mar 26, 2022 · 0 comments
Open

Better Linting #15

awhigham9 opened this issue Mar 26, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@awhigham9
Copy link
Member

We need to specify some stricter linting rules. There is no specific set of rules in mind, but any more comprehensive rule-set from the TypeScript development community would probably do.

We also need to add a npm run lint and npm run lint-fix command to the package.json. These should be:

"scripts": {
  // other commands. . .
  "lint": "eslint . --ext .ts,.tsx",
  "lint-fix": "eslint . --ext .ts,.tsx --fix"
 }

Lastly, we should add a PR workflow check which runs linting and blocks the PR till linting passes.

@awhigham9 awhigham9 added the enhancement New feature or request label Mar 26, 2022
@awhigham9 awhigham9 self-assigned this Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant